Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support decompress 1.3.0 #49

Closed
sternenseemann opened this issue Mar 6, 2021 · 7 comments
Closed

Support decompress 1.3.0 #49

sternenseemann opened this issue Mar 6, 2021 · 7 comments

Comments

@sternenseemann
Copy link

A decompress release has broken imagelib again:

      ocamlc src/.imagelib.objs/byte/imagePNG.{cmi,cmo,cmt} (exit 2)
(cd _build/default && /nix/store/fhp36x8gw9b2g51cy7yfdnmysd2s455k-ocaml-4.10.0/bin/ocamlc.opt -w -40 -g -bin-annot -I src/.imagelib.objs/byte -I /nix/store/bbfxbw8gk1kq82lb2i3alr8qjl6k1pqs-ocaml4.10.0-bigarray-compat-1.0.0/lib/ocaml/4.10.0/site-lib/bigarray-compat -I /nix/store/bbjnkr5yqf3giyh8awldsapk2llycj0d-ocaml4.10.0-checkseum-0.2.1/lib/ocaml/4.10.0/site-lib/checkseum -I /nix/store/bbjnkr5yqf3giyh8awldsapk2llycj0d-ocaml4.10.0-checkseum-0.2.1/lib/ocaml/4.10.0/site-lib/checkseum/ocaml -I /nix/store/h4vfm6rhck6gkz1zrv8qjpshf7ya3vrk-ocaml4.10.0-stdlib-shims-0.3.0/lib/ocaml/4.10.0/site-lib/stdlib-shims -I /nix/store/j346wkf9bcnrxa3zbrx17zg3qqhr6cyj-ocaml4.10.0-decompress-1.3.0/lib/ocaml/4.10.0/site-lib/decompress/de -I /nix/store/j346wkf9bcnrxa3zbrx17zg3qqhr6cyj-ocaml4.10.0-decompress-1.3.0/lib/ocaml/4.10.0/site-lib/decompress/zl -I /nix/store/mwrghjy6dx1s4828y9bi0x12lvpv8yhm-ocaml4.10.0-optint-0.0.4/lib/ocaml/4.10.0/site-lib/optint -no-alias-deps -o src/.imagelib.objs/byte/imagePNG.cmo -c -impl src/imagePNG.ml)
File "src/imagePNG.ml", line 78, characters 77-78:
78 |     match Zl.Higher.uncompress ~allocate:(fun bits -> De.make_window ~bits) ~i ~o ~refill ~flush with
                                                                                  ^
Error: The function applied to this argument has type
         Zl.bigstring -> Zl.bigstring -> (unit, [> `Msg of string ]) result
This argument cannot be applied with label ~i
sternenseemann added a commit to sternenseemann/nixpkgs that referenced this issue Mar 16, 2021
@sternenseemann
ocamlPackages.decompress: 1.2.0 -> 1.3.0
5815770 
Keep decompress 1.2.0 around as decompress-1-2 until imagelib supports
decompress 1.3.0: rlepigre/ocaml-imagelib#49
vbgl pushed a commit to NixOS/nixpkgs that referenced this issue Mar 16, 2021
@sternenseemann
ocamlPackages.git: 3.3.0 -> 3.3.2; decompress: 1.2.0 -> 1.3.0; duff:…
f0b078e 
… 0.3 -> 0.4; and related updates (#116486)

* ocamlPackages.hxd: 0.2.0 -> 0.3.1

ocamlPackages.hxd: disable lwt by default on OCaml 4.06 (syntax error)

* ocamlPackages.duff: 0.3 -> 0.4

* ocamlPackages.decompress: 1.2.0 -> 1.3.0

Keep decompress 1.2.0 around as decompress-1-2 until imagelib supports
decompress 1.3.0: rlepigre/ocaml-imagelib#49

* ocamlPackages.carton*: 0.2.0 -> 0.4.0

* ocamlPackages.git: 3.3.0 -> 3.3.2
@cfcs
Copy link
Collaborator

cfcs commented Mar 30, 2021

@dinosaure do you have an idea how to fix this?

@dinosaure
Copy link
Contributor

I can propose a simple patch, yes 👍.

@cfcs
Copy link
Collaborator

cfcs commented Apr 2, 2021

#50

now we just need a release :) @sternenseemann are you the nix maintainer?

@sternenseemann
Copy link
Author

I can do the imagelib update, yeah :)

@mseri
Copy link
Collaborator

mseri commented Apr 2, 2021

The release is pending on opam-repository, I am closing this issue: ocaml/opam-repository#18434

@mseri mseri closed this as completed Apr 2, 2021
@mseri
Copy link
Collaborator

mseri commented Apr 2, 2021

The corresponding source tarball is available on the github releases

@sternenseemann
Copy link
Author

NixOS/nixpkgs#118314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dinosaure @sternenseemann @mseri @cfcs