Challenge Bug/Errors

[SpaZMonKeY777]

Had a player who couldn't complete the Home Owner challenge, both in the menu and via the in-game command. I checked the rewards and item ID's and everything seemed normal, but it was producing an error in the console whenever they tried to complete it.

Errors: http://pastebin.com/nPakDwTX

[pickledrange]

Confirmed error on v2.0.1-R0.4
Tested working on v2.0.1-R0.3

[dutchy1001]

The "home owner" on v2.0.1-R0.4 works fine for me, make sure you have the right items placed on the island and not in your inventory. This challange can only be done once so unless you alter the player.yml in the players folder you cant repeat this.(I did get this reward only once here, see point below)

I do have an other bug that you get the rewards twice, the first reward and the repeat reward after that repeating the challange will give you twice the repeat reward.

[SpaZMonKeY777]

The player who produced that error when attempting had all blocks placed, and I confirmed in their player file that they did not have it completed yet. Was weird.

[rlf]

The homeowner (and other onIsland challenges) depend on the actual rotation of some of the items.
I.e. for the homeowner, it is currently required, that it's an OAK door that is used, and there might be stuff like the bed-orientation.

Some of these Bugs are the ones I'm currently trying to get rid of, by restructuring a lot of the code.

[rlf]

Please re-test with the R0.5 release

[rlf]

Now R0.7 :)

[pickledrange]

Tested on version R0.7 with stained glass and birch door. No fail message in chat. Error in console.
When tested with normal glass and oak door challenge completed as expected.

[20:19:12] [Server thread/ERROR]: Could not pass event InventoryClickEvent to uSkyBlock v2.0.1-SNAPSHOT-8772ba
org.bukkit.event.EventException
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:305) ~[spigot-1.8.jar:git-Spigot-edf691c-f48410a]
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[spigot-1.8.jar:git-Spigot-edf691c-f48410a]
at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:502) [spigot-1.8.jar:git-Spigot-edf691c-f48410a]
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:487) [spigot-1.8.jar:git-Spigot-edf691c-f48410a]
at net.minecraft.server.v1_8_R1.PlayerConnection.a(PlayerConnection.java:1586) [spigot-1.8.jar:git-Spigot-edf691c-f48410a]
at net.minecraft.server.v1_8_R1.PacketPlayInWindowClick.a(SourceFile:31) [spigot-1.8.jar:git-Spigot-edf691c-f48410a]
at net.minecraft.server.v1_8_R1.PacketPlayInWindowClick.a(SourceFile:9) [spigot-1.8.jar:git-Spigot-edf691c-f48410a]
at net.minecraft.server.v1_8_R1.PacketHandleTask.run(SourceFile:13) [spigot-1.8.jar:git-Spigot-edf691c-f48410a]
at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) [?:1.8.0_25]
at java.util.concurrent.FutureTask.run(Unknown Source) [?:1.8.0_25]
at net.minecraft.server.v1_8_R1.MinecraftServer.z(MinecraftServer.java:683) [spigot-1.8.jar:git-Spigot-edf691c-f48410a]
at net.minecraft.server.v1_8_R1.DedicatedServer.z(DedicatedServer.java:316) [spigot-1.8.jar:git-Spigot-edf691c-f48410a]
at net.minecraft.server.v1_8_R1.MinecraftServer.y(MinecraftServer.java:623) [spigot-1.8.jar:git-Spigot-edf691c-f48410a]
at net.minecraft.server.v1_8_R1.MinecraftServer.run(MinecraftServer.java:526) [spigot-1.8.jar:git-Spigot-edf691c-f48410a]
at java.lang.Thread.run(Unknown Source) [?:1.8.0_25]
Caused by: org.bukkit.command.CommandException: Unhandled exception executing command 'c' in plugin uSkyBlock v2.0.1-SNAPSHOT-8772ba
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46) ~[spigot-1.8.jar:git-Spigot-edf691c-f48410a]
at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:141) ~[spigot-1.8.jar:git-Spigot-edf691c-f48410a]
at org.bukkit.craftbukkit.v1_8_R1.CraftServer.dispatchCommand(CraftServer.java:642) ~[spigot-1.8.jar:git-Spigot-edf691c-f48410a]
at org.bukkit.craftbukkit.v1_8_R1.entity.CraftPlayer.performCommand(CraftPlayer.java:245) ~[spigot-1.8.jar:git-Spigot-edf691c-f48410a]
at us.talabrek.ultimateskyblock.SkyBlockMenu.onClick(SkyBlockMenu.java:1037) ~[?:?]
at us.talabrek.ultimateskyblock.PlayerJoin.guiClick(PlayerJoin.java:149) ~[?:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_25]
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_25]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_25]
at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_25]
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:301) ~[spigot-1.8.jar:git-Spigot-edf691c-f48410a]
... 14 more
Caused by: java.lang.ArrayIndexOutOfBoundsException: 398458880
at us.talabrek.ultimateskyblock.challenge.ChallengeLogic.islandContains(ChallengeLogic.java:190) ~[?:?]
at us.talabrek.ultimateskyblock.challenge.ChallengeLogic.tryCompleteOnIsland(ChallengeLogic.java:223) ~[?:?]
at us.talabrek.ultimateskyblock.challenge.ChallengeLogic.tryComplete(ChallengeLogic.java:173) ~[?:?]
at us.talabrek.ultimateskyblock.challenge.ChallengeLogic.completeChallenge(ChallengeLogic.java:133) ~[?:?]
at us.talabrek.ultimateskyblock.challenge.ChallengesCommand.onCommand(ChallengesCommand.java:72) ~[?:?]
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44) ~[spigot-1.8.jar:git-Spigot-edf691c-f48410a]
at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:141) ~[spigot-1.8.jar:git-Spigot-edf691c-f48410a]
at org.bukkit.craftbukkit.v1_8_R1.CraftServer.dispatchCommand(CraftServer.java:642) ~[spigot-1.8.jar:git-Spigot-edf691c-f48410a]
at org.bukkit.craftbukkit.v1_8_R1.entity.CraftPlayer.performCommand(CraftPlayer.java:245) ~[spigot-1.8.jar:git-Spigot-edf691c-f48410a]
at us.talabrek.ultimateskyblock.SkyBlockMenu.onClick(SkyBlockMenu.java:1037) ~[?:?]
at us.talabrek.ultimateskyblock.PlayerJoin.guiClick(PlayerJoin.java:149) ~[?:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_25]
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_25]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_25]
at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_25]
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:301) ~[spigot-1.8.jar:git-Spigot-edf691c-f48410a]
... 14 more

[rlf]

Ouch... BirchDoor... Ouch...

[pickledrange]

hey was just picking something that wasnt oak, dont judge me :P

[pickledrange]

Seems to be working ok. Hopefully SpaZMonKeY777 can confirm working for him, I havent tested rotations, too many combinations XD

[dutchy1001]

Just a mistake i found in rewards given from the "applecollector" discription says 1 of each sapling, but it gives 2 of oak,birch, jungle and spruce. The acasia and dark oak are not there. This is an easy fix

Edit, the repeat reward is set right

[pickledrange]

I keep changing that and it keeps getting changed back...

[pickledrange]

I've changed the 1 to a 2 in about 3 edits I've made now

[dutchy1001]

lol, all saplings should be 1 except dark oak as you need 4 of them to grow, I would suggest to give them 2 of those and let them repeat the challenge for the next 2 lol

[pickledrange]

Personally I think it is right. Diminished rewards for repeat is normal. So 2 first and 1 second. I make you right though. I'll make those edits tonight. Also I feel glass maker needs a reward review. It's a duplicate of wool collector by looks of it

[pickledrange]

So 1 dark oak in the repeat? Or 2. Don't want it too easy lol

[dutchy1001]

2 dark oak in the repeat, it is not that often apples fall out a tree

[pickledrange]

Ok. Can you have a think on glass maker rewards. I'm thinking sand should be there instead of sheep. I'll make changes when I get home from work.

[rlf]

I agree with the 2 saplings (matches my servers config).
But... can't we close this issue now?

[pickledrange]

I believe yes