[SMALLFIX] Lack of env var CIRCLECI should not forbid running experiments #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removing this will break the tests on Circle CI. If you run the code again it should not print this message again, since a |
|
Okay, it works for me. But mentioning configuration for integration testing in the main library code does not sound like a good idea to me. |
ghost
closed this
jonashen
pushed a commit
to jonashen/rllab
that referenced
this pull request
May 29, 2018
It was verified that each of the dependencies removed were not imported or had any package dependants in rllab. The new environment file was tested with a fresh copy of the rllab project by running the setup_linux script, and with the training of the swimmer in Theano and cartpole in TensorFlow with plot=True. The channels of the removed packages were discarded as well.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After installing anaconda and running ./scripts/setup_osx.sh,
python examples/ddpg_cartpole_stub.pyfails withThis is because of the code deleted in this PR. I don't think running an experiment needs to set env vars for an integration system, the
ifblock should be deleted.Currently, I work around this problem by exporting
CIRCLECIto be an arbitrary non-empty string.