Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump django-crispy-forms from 1.14.0 to 2.0 #332

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Feb 13, 2023

Bumps django-crispy-forms from 1.14.0 to 2.0.

Release notes

Sourced from django-crispy-forms's releases.

2.0 (2023-02-13)

Major Changes and Migration Guide

  • Removed all Bootstrap template packs. These template packs are now available as standalone packages. To upgrade, install the required template pack and add it to your INSTALLED_APPS setting.

    Also, support for Bootstrap 5 is provided by a 3rd party package under the django-crispy-forms organisation at crispy-bootstrap5.

  • Removed uni-form template pack. Uni-Form specific classes previously added to every template pack e.g. textInput are now removed. If you require these classes, the previous behaviour can be restored by adding the following to CRISPY_CLASS_CONVERTERS in your settings file.

      converters = {
        "textinput": "textinput textInput",
        "fileinput": "fileinput fileUpload",
        "passwordinput": "textinput textInput",
    }
    
  • The uni-form template pack allowed for rendering of templates using a default or inline layout. As the uni-form template pack has been removed support for this has also been removed. This has resulted in the following BREAKING changes.

    • The form_style attribute of FormHelper is removed.
    • The form_style positional argument to render_field() is removed.
    • The form_style positional argument to the render() method of all LayoutObjects is removed.

    Audit for use of render() and render_field() due to the removal of the form_style positional argument is therefore required. For example:

    # django-crispy-forms 1.x
    html = my_layout_object.render(form, form_style, context)
    # django-crispy-forms 2.x
    html = my_layout_object.render(form, context)
    
  • Widespread use of the |safe in crispy-form templates is removed. Audit for html input in your forms especially for Field and Prepended/Appended text. To retain the previous behaviour mark text as safe in your project code using mark_safe(). Refs #296.

Other Changes

  • Dropped support for Django 2.2.
  • Added support for Django 4.1 and 4.2.

... (truncated)

Changelog

Sourced from django-crispy-forms's changelog.

2.0 (2023-03-13)

Release of django-crispy-forms 2.0. No changes introduced since 2.0a1.

2.0a1 (2023-01-18)

Major Changes and Migration Guide

  • Removed all Bootstrap template packs. These template packs are now available as standalone packages. To upgrade, install the required template pack and add it to your INSTALLED_APPS setting.

    Also, support for Bootstrap 5 is provided by a 3rd party package under the django-crispy-forms organisation at crispy-bootstrap5.

  • Removed uni-form template pack. Uni-Form specific classes previously added to every template pack e.g. textInput are now removed. If you require these classes, the previous behaviour can be restored by adding the following to CRISPY_CLASS_CONVERTERS in your settings file.

      converters = {
        "textinput": "textinput textInput",
        "fileinput": "fileinput fileUpload",
        "passwordinput": "textinput textInput",
    }
    
  • The uni-form template pack allowed for rendering of templates using a default or inline layout. As the uni-form template pack has been removed support for this has also been removed. This has resulted in the following BREAKING changes.

    • The form_style attribute of FormHelper is removed.
    • The form_style positional argument to render_field() is removed.
    • The form_style positional argument to the render() method of all LayoutObjects is removed.

    Audit for use of render() and render_field() due to the removal of the form_style positional argument is therefore required. For example:

    # django-crispy-forms 1.x
    html = my_layout_object.render(form, form_style, context)
    # django-crispy-forms 2.x
    html = my_layout_object.render(form, context)
    
  • Widespread use of the |safe in crispy-form templates is removed. Audit for html input in your forms especially for Field and Prepended/Appended text. To retain the previous behaviour mark text as safe in your project code using mark_safe(). Refs #296.

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@coveralls
Copy link

coveralls commented Feb 13, 2023

Coverage Status

Coverage: 80.986%. Remained the same when pulling 6f1b71e on dependabot/pip/django-crispy-forms-2.0 into 1cabb82 on main.

@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (bcfedbf) 76.80% compared to head (ec2ddbc) 76.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #332   +/-   ##
=======================================
  Coverage   76.80%   76.80%           
=======================================
  Files          11       11           
  Lines        1276     1276           
  Branches      175      175           
=======================================
  Hits          980      980           
  Misses        243      243           
  Partials       53       53           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dependabot dependabot bot force-pushed the dependabot/pip/django-crispy-forms-2.0 branch from 1447a4f to 19f1e77 Compare February 14, 2023 22:37
@dependabot dependabot bot force-pushed the dependabot/pip/django-crispy-forms-2.0 branch 3 times, most recently from 6caf9c1 to eac33af Compare February 27, 2023 00:33
@dependabot dependabot bot force-pushed the dependabot/pip/django-crispy-forms-2.0 branch 6 times, most recently from 4099166 to 97ebbf4 Compare March 30, 2023 00:25
@dependabot dependabot bot force-pushed the dependabot/pip/django-crispy-forms-2.0 branch 3 times, most recently from 3cafd4e to 6f1b71e Compare April 10, 2023 23:54
@rloomans
Copy link
Owner

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/pip/django-crispy-forms-2.0 branch from 6f1b71e to 4c5b48f Compare April 20, 2023 00:46
@rloomans
Copy link
Owner

@dependabot rebase

@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Apr 20, 2023

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@rloomans rloomans temporarily deployed to e8temp-pipel-dependabot-fwfz1o April 20, 2023 02:28 Inactive
@rloomans rloomans force-pushed the dependabot/pip/django-crispy-forms-2.0 branch from 87ea2fc to ec2ddbc Compare April 20, 2023 03:03
@rloomans rloomans temporarily deployed to e8temp-pipel-dependabot-wgrbog April 20, 2023 03:03 Inactive
@rloomans rloomans merged commit dc9c541 into main Apr 20, 2023
@rloomans rloomans deleted the dependabot/pip/django-crispy-forms-2.0 branch April 20, 2023 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants