Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add french translation #52

Merged
merged 7 commits into from
Jan 23, 2021
Merged

Add french translation #52

merged 7 commits into from
Jan 23, 2021

Conversation

Incremental92
Copy link
Contributor

French translation with some english terms kept for clarity.

rluders
rluders requested changes Jan 17, 2021
View reviewed changes
Copy link
Owner

@rluders rluders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some places where you are using single quotes inside the single quotes string on PHP. I don't think that it would be a good idea. How about replacing the string single quotes to use double quotes?

lang/fr-fr/lang.php Outdated Show resolved Hide resolved
@Incremental92
Copy link
Contributor Author

OK I will change it.

@Incremental92
Copy link
Contributor Author

I made the correction.

@rluders rluders linked an issue Jan 22, 2021 that may be closed by this pull request
French translation ? #50
Closed
@rluders rluders self-requested a review January 23, 2021 18:49
@rluders rluders merged commit bf13bf0 into rluders:main Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rluders rluders Awaiting requested review from rluders

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

French translation ?
2 participants
@Incremental92 @rluders