Make FiniteDifferenceHvp pickleable #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahtsan
requested review from
ryanjulian,
naeioi,
CatherineSue,
zhanpenghe and
krzentner
Codecov Report
@@ Coverage Diff @@
## master #745 +/- ##
==========================================
+ Coverage 67.57% 67.59% +0.01%
==========================================
Files 164 164
Lines 10197 10201 +4
Branches 1335 1335
==========================================
+ Hits 6891 6895 +4
Misses 2958 2958
Partials 348 348
Continue to review full report at Codecov.
|
|
@ahtsan can you add a test which would have caught this bug? i think you can just run one step of TRPO with the LSTM policy. |
ryanjulian
reviewed
Jun 24, 2019
krzentner
reviewed
Jun 24, 2019
| del new_dict['opt_fun'] | ||
| return new_dict | ||
|
|
||
| def __setstate__(self, state): |
There was a problem hiding this comment.
Do you need to re-create opt_fun here?
If you don't, then you should be able to delete this __setstate__ implementation, since this is the "default."
Note that you'll still have a __getstate__ implementation then, despite not having a __setstate__ implementation.
There was a problem hiding this comment.
Good catch, will remove __getstate__ since opt_fun is recreated somewhere else.
zhanpenghe
approved these changes
Jun 24, 2019
CatherineSue
approved these changes
Jun 25, 2019
ryanjulian
approved these changes
Jun 25, 2019
krzentner
pushed a commit
that referenced
this pull request
Jun 27, 2019
Currently all policies using `FiniteDifferenceHvp` in `examples/tf/` don't work because `FiniteDifferenceHvp` is not pickleable. This PR fixes the issue, and also update outdated arguments in some TRPO usage.
gitanshu
pushed a commit
that referenced
this pull request
Jun 27, 2019
Currently all policies using `FiniteDifferenceHvp` in `examples/tf/` don't work because `FiniteDifferenceHvp` is not pickleable. This PR fixes the issue, and also update outdated arguments in some TRPO usage.
gitanshu
pushed a commit
that referenced
this pull request
Jun 27, 2019
Currently all policies using `FiniteDifferenceHvp` in `examples/tf/` don't work because `FiniteDifferenceHvp` is not pickleable. This PR fixes the issue, and also update outdated arguments in some TRPO usage.
gitanshu
pushed a commit
that referenced
this pull request
Jun 28, 2019
Currently all policies using `FiniteDifferenceHvp` in `examples/tf/` don't work because `FiniteDifferenceHvp` is not pickleable. This PR fixes the issue, and also update outdated arguments in some TRPO usage.
avnishn
pushed a commit
that referenced
this pull request
Jun 28, 2019
* Make FiniteDifferenceHvp pickleable (#745) Currently all policies using `FiniteDifferenceHvp` in `examples/tf/` don't work because `FiniteDifferenceHvp` is not pickleable. This PR fixes the issue, and also update outdated arguments in some TRPO usage. * Convert tests to run with pytest * Use pytest-cov for coverage * Fix broken tests * Fix code formatting * Fix more formatting * Fix typo in TestSanpshotter class name * Update new tests to use pytest format
ahtsan
added a commit
that referenced
this pull request
Jun 30, 2019
Currently all policies using `FiniteDifferenceHvp` in `examples/tf/` don't work because `FiniteDifferenceHvp` is not pickleable. This PR fixes the issue, and also update outdated arguments in some TRPO usage.
zequnyu
pushed a commit
that referenced
this pull request
Jul 1, 2019
Currently all policies using `FiniteDifferenceHvp` in `examples/tf/` don't work because `FiniteDifferenceHvp` is not pickleable. This PR fixes the issue, and also update outdated arguments in some TRPO usage.
ahtsan
added a commit
that referenced
this pull request
Jul 2, 2019
Currently all policies using `FiniteDifferenceHvp` in `examples/tf/` don't work because `FiniteDifferenceHvp` is not pickleable. This PR fixes the issue, and also update outdated arguments in some TRPO usage.
ahtsan
added a commit
that referenced
this pull request
Jul 2, 2019
Currently all policies using `FiniteDifferenceHvp` in `examples/tf/` don't work because `FiniteDifferenceHvp` is not pickleable. This PR fixes the issue, and also update outdated arguments in some TRPO usage.
nish21
pushed a commit
that referenced
this pull request
Jul 3, 2019
Currently all policies using `FiniteDifferenceHvp` in `examples/tf/` don't work because `FiniteDifferenceHvp` is not pickleable. This PR fixes the issue, and also update outdated arguments in some TRPO usage.
ahtsan
added a commit
that referenced
this pull request
Jul 3, 2019
Currently all policies using `FiniteDifferenceHvp` in `examples/tf/` don't work because `FiniteDifferenceHvp` is not pickleable. This PR fixes the issue, and also update outdated arguments in some TRPO usage.
nish21
pushed a commit
that referenced
this pull request
Jul 4, 2019
Currently all policies using `FiniteDifferenceHvp` in `examples/tf/` don't work because `FiniteDifferenceHvp` is not pickleable. This PR fixes the issue, and also update outdated arguments in some TRPO usage.
ahtsan
added a commit
that referenced
this pull request
Jul 5, 2019
Currently all policies using `FiniteDifferenceHvp` in `examples/tf/` don't work because `FiniteDifferenceHvp` is not pickleable. This PR fixes the issue, and also update outdated arguments in some TRPO usage.
nish21
pushed a commit
that referenced
this pull request
Jul 6, 2019
Currently all policies using `FiniteDifferenceHvp` in `examples/tf/` don't work because `FiniteDifferenceHvp` is not pickleable. This PR fixes the issue, and also update outdated arguments in some TRPO usage.
nish21
pushed a commit
that referenced
this pull request
Jul 11, 2019
Currently all policies using `FiniteDifferenceHvp` in `examples/tf/` don't work because `FiniteDifferenceHvp` is not pickleable. This PR fixes the issue, and also update outdated arguments in some TRPO usage.
nish21
pushed a commit
that referenced
this pull request
Jul 23, 2019
Currently all policies using `FiniteDifferenceHvp` in `examples/tf/` don't work because `FiniteDifferenceHvp` is not pickleable. This PR fixes the issue, and also update outdated arguments in some TRPO usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all policies using
FiniteDifferenceHvpinexamples/tf/don't work becauseFiniteDifferenceHvpis not pickleable.This PR fixes the issue, and also update outdated arguments in some TRPO usage.