Expose the pullup resistor constants to API users. #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These weren't being exposed as part of the GPIO module, so callers
were getting error messages like this:
$ python ../gpio_button_edge_detect.py
Traceback (most recent call last):
File "../gpio_button_edge_detect.py", line 11, in <module>
GPIO.setup(pin, GPIO.IN, pull_up_down=GPIO.PUD_DOWN)
AttributeError: module 'OPi.GPIO' has no attribute 'PUD_DOWN'
rm-hull
previously approved these changes
Jan 11, 2019
|
@mikalstill the QA check failed ... have a look at https://travis-ci.org/rm-hull/OPi.GPIO/jobs/478266740#L696. I think we probably need a Could you amend the PR please? |
rm-hull
dismissed
their stale review
Build fails because of flake8 violations; please add noqa comments
|
No problems, done. |
|
thank you |
rm-hull
approved these changes
Jan 11, 2019
|
I'll push out a new release with this change in over the weekend. |
|
https://pypi.org/project/OPi.GPIO/0.3.6/ released with this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These weren't being exposed as part of the GPIO module, so callers
were getting error messages like this:
$ python ../gpio_button_edge_detect.py
Traceback (most recent call last):
File "../gpio_button_edge_detect.py", line 11, in
GPIO.setup(pin, GPIO.IN, pull_up_down=GPIO.PUD_DOWN)
AttributeError: module 'OPi.GPIO' has no attribute 'PUD_DOWN'