-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show better error message for sevensegment demo #76
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8c80500
show better error message for sevensegment demo usage with unsupporte…
thijstriemstra 7a26ff8
Merge branch 'master' into 7seg-71
rm-hull c4c70fd
display settings before attempting to create device
thijstriemstra 64e5ed1
Merge branch 'master' into 7seg-71
rm-hull 937eb9c
Test for 'segment_mapper' attribute
rm-hull 13ee63d
missing device name
rm-hull File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,7 @@ | |
Example for seven segment displays. | ||
""" | ||
|
||
import sys | ||
import time | ||
from datetime import datetime | ||
|
||
|
@@ -68,6 +69,11 @@ def show_message_alt(seg, msg, delay=0.1): | |
def main(): | ||
# create seven segment device | ||
device = get_device() | ||
|
||
if not hasattr(device, 'segment_mapper'): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmmm - thinking about it, this check would be better off in the |
||
sys.exit('sevensegment is not supported on a {} device'.format( | ||
device.__class__.__name__)) | ||
|
||
seg = sevensegment(device) | ||
|
||
print('Simple text...') | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense 👍