Support neosegment displays #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feature/neosegment * 'master' of git://github.com/rm-hull/luma.led_matrix: Alternative WS2812 implementation (#113)
thijstriemstra
requested changes
Jul 20, 2017
doc/python-usage.rst
Outdated
| NeoSegments | ||
| """"""""""" | ||
| `@msurguy <https://twitter.com/msurguy?lang=en>`_ has `crowdsourced some WS2812 neopixels <https://www.crowdsupply.com/maksmakes/neosegment>`_ | ||
| into a modular 3D-printed seven-segment module: To program these devices: |
There was a problem hiding this comment.
Replace seven-segment module: with seven-segment module..
doc/python-usage.rst
Outdated
| neoseg.color = "green" | ||
|
|
||
| The :py:class:`~luma.led_matrix.device.neosegment` class extends :py:class:`~luma.core.virtual.sevensegment`, | ||
| so the same text assignment (python slicing paradigms) can be use here as well - |
There was a problem hiding this comment.
- Python with a capital
- 'use' should be 'used'
| from neopixel_demo import gfx | ||
|
|
||
|
|
||
| def rainbow(n=1000, saturation=1, value=1): |
There was a problem hiding this comment.
a docstring for this method would be nice.
luma/led_matrix/device.py
Outdated
| techniques as the base class, but provides additional functionality to be | ||
| able to adddress individual characters colors. | ||
|
|
||
| :param width: the number of 7-segment elements that are cascaded. |
There was a problem hiding this comment.
'the' should be 'The'.
tests/test_neosegment.py
Outdated
| @@ -0,0 +1,93 @@ | |||
| #!/usr/bin/env python | |||
| # -*- coding: utf-8 -*- | |||
| # Copyright (c) 2014-17 Richard Hull and contributors | |||
tests/test_neosegment.py
Outdated
| # Copyright (c) 2014-17 Richard Hull and contributors | ||
| # See LICENSE.rst for details. | ||
|
|
||
| import pytest |
There was a problem hiding this comment.
(optional..) missing docstring for this module.
msurguy
approved these changes
Jul 20, 2017
thijstriemstra
approved these changes
Jul 20, 2017
|
luma.led_matrix 0.11.0 released with the feature included |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #106
Rendered documentation here: http://luma-led-matrix.readthedocs.io/en/feature-neosegment/python-usage.html#neosegments