Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De la guardo setup clojure 34 #107

Merged
merged 19 commits into from
Nov 19, 2021
Merged

De la guardo setup clojure 34 #107

merged 19 commits into from
Nov 19, 2021

Conversation

seancorfield
Copy link
Contributor

Update CLI to 1.10.3.1029 for CI and manually install tools.tools so clojure -Ttools works.

This is a workaround for DeLaGuardo/setup-clojure#34

@seancorfield
Copy link
Contributor Author

Ugh! I should have rebased that against master after updating it. I guess you can squash it to a single commit in the PR?

@coveralls
Copy link

coveralls commented Nov 19, 2021

Pull Request Test Coverage Report for Build 1481414130

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.8%) to 50.973%

Totals Coverage Status
Change from base Build 1478823455: 0.8%
Covered Lines: 131
Relevant Lines: 257

💛 - Coveralls

@vemv
Copy link
Collaborator

vemv commented Nov 19, 2021

Hey there!

First of all kudos for the debugging rampage 👏

What would you think of PRing against setup-clojure?

I wouldn't mind keeping nvd-clojure red for a while - in the end I know that all tests are passing.

@seancorfield
Copy link
Contributor Author

I don't know enough TypeScript to submit a PR against setup-clojure 😄 I created an issue there (linked above) and DeLaGuardo said he'd take a look later today.

Definitely sounds reasonable at this point to keep nvd-clojure red until setup-clojure is fixed so feel free to close this out.

@rm-hull
Copy link
Owner

rm-hull commented Nov 19, 2021

@seancorfield dont worry about the commits on the branch, we usually squash/merge anyway

@vemv vemv merged commit 5fd1307 into rm-hull:master Nov 19, 2021
@vemv
Copy link
Collaborator

vemv commented Nov 19, 2021

The diff is small enough that it can be easily reverted later.

Thanks again for the efforts! 😊

@seancorfield seancorfield deleted the DeLaGuardo-setup-clojure-34 branch November 19, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants