-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
De la guardo setup clojure 34 #107
De la guardo setup clojure 34 #107
Conversation
I'd like to see the output of both of these commands prior to the tools install failing, to verify what version/tools the CLI thinks are present.
Alex cannot repro and I've never seen this behavior outside of this CI pipeline.
Ugh! I should have rebased that against master after updating it. I guess you can squash it to a single commit in the PR? |
Pull Request Test Coverage Report for Build 1481414130Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Hey there! First of all kudos for the debugging rampage 👏 What would you think of PRing against I wouldn't mind keeping nvd-clojure red for a while - in the end I know that all tests are passing. |
I don't know enough TypeScript to submit a PR against Definitely sounds reasonable at this point to keep nvd-clojure red until |
@seancorfield dont worry about the commits on the branch, we usually squash/merge anyway |
The diff is small enough that it can be easily reverted later. Thanks again for the efforts! 😊 |
Update CLI to 1.10.3.1029 for CI and manually install
tools.tools
soclojure -Ttools
works.This is a workaround for DeLaGuardo/setup-clojure#34