set ARCHFLAGS appropriately for OSX (#169) #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # set ARCHFLAGS appropriately for OSX | ||
| def set_archflags_for_osx | ||
| archflags = [] | ||
| fullpath = `which convert` rescue nil |
There was a problem hiding this comment.
Avoid using rescue in its modifier form.
| end | ||
|
|
||
| if archflags.length != 0 | ||
| $ARCH_FLAG = archflags.join(' ') |
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
There was a problem hiding this comment.
Is double quotes the route we want to go? I'm preferential to single quotes.
|
Great job! I hope that Hound did not disappoint you very much :) Thanks for fixing it. |
vassilevsky
added a commit
that referenced
this pull request
Feb 16, 2015
Set ARCHFLAGS appropriately on OS X
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #169
To check ImageMagick architectures
filecommand: