Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not test machine and OS-specific integers #91

Merged
merged 3 commits into from
Aug 11, 2014
Merged

Do not test machine and OS-specific integers #91

merged 3 commits into from
Aug 11, 2014

Conversation

vassilevsky
Copy link
Member

These values are machine and OS-dependent.
ImageMagick 6.8.9 (r15243) has the following definitions:

magick/resource.c:110:

MagickULLConstant(1536)*1024*1024, /* memory limit */
MagickULLConstant(3072)*1024*1024, /* map limit */
MagickResourceInfinity,            /* disk limit */
MagickULLConstant(768),            /* file limit */

magick/magick-type.h:36:

#  define MagickULLConstant(c)  (MagickSizeType) (c ## ULL)

magick/magick-type.h:151:

typedef unsigned long long MagickSizeType;

When building on Windows, other definitions take place.
So, I think the initial values should not be in the tests at all.

@ioquatix
Copy link
Contributor

@vassilevsky Okay, sweet, please add one more patch to test that the values are "sane" and then lets merge.

ioquatix added a commit that referenced this pull request Aug 11, 2014
Do not test machine and OS-specific integers
@ioquatix ioquatix merged commit ba8df86 into rmagick:master Aug 11, 2014
@ioquatix
Copy link
Contributor

@vassilevsky Thanks for the awesome work - now we only have two failing test cases and they mostly look pretty trivial.

@vassilevsky vassilevsky deleted the limits-testing branch August 11, 2014 06:00
@vassilevsky
Copy link
Member Author

Everything looks trivial at first glance...

@linduxed
Copy link
Contributor

Please close relevant issues over in this milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants