Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup lint checking #22

Closed
rmariano opened this issue Mar 2, 2017 · 0 comments
Closed

Setup lint checking #22

rmariano opened this issue Mar 2, 2017 · 0 comments
Labels
CI enhancement test
Projects
Version 0.2

Comments

@rmariano
Copy link
Owner

rmariano commented Mar 2, 2017

make lint should be part of the checklist, and should run linting checks automatically (pycodestyle, pylint, etc.).

If some issues are found on any of the files, it should fail with exit code 1.
@rmariano rmariano mentioned this issue Mar 2, 2017
Closed
@rmariano rmariano added this to TODO in Version 0.2 Mar 22, 2017
rmariano added a commit that referenced this issue Mar 28, 2017
@rmariano
linting: make lint
f69e18d 
Run the pylint automatically in the project, and fail on non-compliance.
It's integrated with the checklist, but not the tests.

It remains to be checked in the CI

Fixes #22
@rmariano rmariano moved this from TODO to DONE :smiley: in Version 0.2 Apr 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI enhancement test
Projects
Version 0.2
DONE :smiley:
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rmariano