-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed abagen.mouse column ordering #62
Conversation
Hey @rmarkello -- I fixed the issue with your proposal and I also added an |
Pull Request Test Coverage Report for Build 226
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @abkosar ! This looks great—thank you so much!
I made one suggestion that I think should fix the Travis failure; it's a linting error caused by flake8
expecting two blank line before a function definition in test_io.py
. If you want to accept the suggestion then the tests should re-run and this should all be perfect!
Thank you again 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rmarkello! Looks great, yeah I wasn't paying attention to spacing.
Hey @abkosar: if you could accept the suggestion to add the blank line that would be great! I'm not able to do it myself, but as soon as you do I'll go ahead and merge. Thanks again! |
Co-Authored-By: Ross Markello <rossmarkello@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
==========================================
+ Coverage 97.16% 97.17% +<.01%
==========================================
Files 24 24
Lines 954 957 +3
==========================================
+ Hits 927 930 +3
Misses 27 27
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
==========================================
+ Coverage 97.16% 97.17% +<.01%
==========================================
Files 24 24
Lines 954 957 +3
==========================================
+ Hits 927 930 +3
Misses 27 27
Continue to review full report at Codecov.
|
Hey @rmarkello -- I think everything looks good! |
This was great ! Thanks again so much for the contribution, @abkosar ! |
#56