Restructuring with model observer for 5.3 compatibility #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restructured most of the trait to an independant model observer that makes using this on 5.3 possible, with a little extra code. Moved test models out to separate files so that they can be included as needed (5.3 raises syntax errors if it finds a class with a use-trait).
ghost
assigned Fixes #2 There are 3 new traits - CreatedBy, UpdatedBy and DeletedBy, that add the default relationship accessor when used with the user class defined in the configuration. Blameable is sticking around as a way of interrogating whether a model is blameable for an event (most of the time you don't need to add it). It turns out that traits can't extend other traits - they have to inherit from them (i.e. use ParentTrait). This causes probelsm when you want several traits to inherit a method, and then use several of those traits in one class - the methods inherited from the base trait clash against themselves! I'm developing on 5.4 so this might have been fixed in 5.5...
…ber to update it
|
Composer is taking 2 hours to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for working towards issue #6.