Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructuring with model observer for 5.3 compatibility #7

Merged
merged 6 commits into from
Jul 25, 2013
Merged

Restructuring with model observer for 5.3 compatibility #7

merged 6 commits into from
Jul 25, 2013

Commits on Jul 19, 2013

  1. Restructured to use a model observer, passing tests on 5.3 

    Restructured most of the trait to an independant model observer that makes
using this on 5.3 possible, with a little extra code.

Moved test models out to separate files so that they can be included as needed
(5.3 raises syntax errors if it finds a class with a use-trait).
    @rmasters
    rmasters committed Jul 19, 2013
    Configuration menu
    Copy the full SHA
    e7f5db2 View commit details
    Browse the repository at this point in the history

  2. Allow 5.3 in composer

    @rmasters
    rmasters committed Jul 19, 2013
    Configuration menu
    Copy the full SHA
    688ee33 View commit details
    Browse the repository at this point in the history

  3. Separated traits as required 

    Fixes #2

There are 3 new traits - CreatedBy, UpdatedBy and DeletedBy, that add the
default relationship accessor when used with the user class defined in the
configuration.

Blameable is sticking around as a way of interrogating whether a model is
blameable for an event (most of the time you don't need to add it).

It turns out that traits can't extend other traits - they have to inherit from
them (i.e. use ParentTrait). This causes probelsm when you want several traits
to inherit a method, and then use several of those traits in one class - the
methods inherited from the base trait clash against themselves! I'm developing
on 5.4 so this might have been fixed in 5.5...
    @rmasters
    rmasters committed Jul 19, 2013
    Configuration menu
    Copy the full SHA
    743d34b View commit details
    Browse the repository at this point in the history

  4. Fix trait docblocks

    @rmasters
    rmasters committed Jul 19, 2013
    Configuration menu
    Copy the full SHA
    ee6f5bb View commit details
    Browse the repository at this point in the history

  5. Add missing file doc headers, remove @Version tag as I'll never remem… 

    …ber to update it
    @rmasters
    rmasters committed Jul 19, 2013
    Configuration menu
    Copy the full SHA
    904569a View commit details
    Browse the repository at this point in the history

  6. Update composer.lock to allow PHP 5.3.0

    @rmasters
    rmasters committed Jul 19, 2013
    Configuration menu
    Copy the full SHA
    982477a View commit details
    Browse the repository at this point in the history