Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Associcate idle periods with similar-origin window agent #1

Open
wants to merge 2 commits into
base: event_loop_start
Choose a base branch
from

Conversation

rmcilroy
Copy link
Owner

@rmcilroy rmcilroy commented Oct 30, 2019

The idle callback lists and idle periods should be per-similar-origin window
agent, rather than per-window. This change moves the lists and the starting
of idle periods to be on a per-event loop basis.

Addresses w3c#82

The idle callback lists and idle periods should be per-event loop
rather than per-window. This change moves the lists and the starting
of idle periods to be on a per-event loop basis.

Addresses w3c#82
index.html Outdated
<li>An <dfn>idle callback identifier</dfn>, which is a number which MUST
initially be zero.</li>
</ul>

<p>In addition, each <a>event loop</a> has:</p>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be cleaner to use the similar-origin window agent here as the ordering is only supposed to be observable within such an agent. That's also what we do for mutation observers.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, that makes sense. Is there an easy way to get the all the similar-origin window agents associated with an event loop (i.e., for step 11 of the event loop processing model)?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. @domenic?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concrete <dfn> you can link to. But IMO something like

all similar-origin window agents that use event loop

is well-defined, given the definition at https://html.spec.whatwg.org/#window-event-loop

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I've switch this over to similar-origin window agent.

@rmcilroy rmcilroy changed the title Associcate idle callback lists and idle periods with the event loop. Associcate idle periods with similar-origin window agent Oct 30, 2019
<li>A <dfn>list of idle request callbacks</dfn>. The list MUST be
initially empty and each entry in this list is identified by <a>Window</a>
and a number, the combination of which MUST be unique within the list for
the lifetime of the <a>similar-origin window agent</a>.</li>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second requirement should probably fall out of how you mutate the list and not be redundantly required here (a note indicating the uniqueness might be nice though). Same below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants