Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Libation v9 #418

Closed
rmcrackan opened this issue Dec 20, 2022 · 39 comments
Closed

Libation v9 #418

rmcrackan opened this issue Dec 20, 2022 · 39 comments

Comments

@rmcrackan
Copy link
Owner

@Mbucari , @pixil98 -- To my knowledge, all 3 of us have completed all major pending efforts. I'm ready to publicly announce Libation v9 and take mac and linux out of beta. Well, maybe I'll do 1 more release first so if the latest changes broke something, they won't first come to light during a major announcement.

Anything I should wait on?

pixel98: what's your reddit name? Barring objections: when advertising it there, I want to credit you by username .
@Mbucari
Copy link
Collaborator

Mbucari commented Dec 20, 2022 •
edited
Loading

@rmcrackan Nothing more from me in the near future. I'm feeling really good about the recent changes and chardonnay refactoring.

FYI, I'm out of town until Wednesday the 28th.

@rmcrackan
Copy link
Owner Author

Good reminder: that's the other thing. We likely don't want to release v9 until the new year -- just as true today as it was 5 years ago

@pixil98
Copy link
Contributor

pixil98 commented Dec 20, 2022

No objections to being credited, my username is on Reddit is pixil. Good call on waiting until the new year. It might be worth cutting a tag now just to make sure the pipelines work correctly and it publishes to docker hub. I spent all my vacation already so I'll be around if it needs any fixes before the big release.

@wtanksleyjr
Copy link
Contributor

wtanksleyjr commented Dec 20, 2022 via email

@rmcrackan
Copy link
Owner Author

I've initiated v8.7. I expect it live within the hour

@rmcrackan
Copy link
Owner Author

@pixil98

  • I pushed the new v8.7.0 tag
  • Some actions occurred successfully incl. building artifacts
  • The releases page does not have a new draft
  • My docker repo is empty

@pixil98
Copy link
Contributor

pixil98 commented Dec 20, 2022 •
edited
Loading

For some reason the workflow didn't trigger on the tag being created. Under actions there is nothing listed for the release workflow, just validate. I just tried testing it on my identical forked repo and it worked fine. How are you creating and pushing the tag?

@rmcrackan
Copy link
Owner Author 

git tag v8.7.0
git push --tags

@Mbucari
Copy link
Collaborator

Mbucari commented Dec 21, 2022

I just tested these workflows on my repo. I created a new release with a new tag at the same time, and all of the workflows triggered as expected.

https://github.com/Mbucari/Libation/actions/runs/3745722351

@rmcrackan
Copy link
Owner Author

What was your method for creating a new release and new tag? I had pushed my code. Then separately created and pushed the tag

@Mbucari
Copy link
Collaborator

Mbucari commented Dec 21, 2022

I just used GitHub's web GUI. Draft a new release > choose a tag.

Then I add a new tag, and GitHub creates it when I publish the release.

@pixil98
Copy link
Contributor

pixil98 commented Dec 21, 2022

Can you try deleting the tag and recreating it or creating a new tag? I don’t see a problem with how you created the tag. I generally create the tag and push it specifically, git push origin v8.7.0

@rmcrackan
Copy link
Owner Author

Weird. git push origin v8.7.0 worked. This is how people become superstitious!

@rmcrackan
Copy link
Owner Author

Ok you docker weirdos :) it's showing up there now too

rmcrackan/libation

latest (and only) is 8.7.0

@rmcrackan
Copy link
Owner Author

@pixil98 , @Mbucari I don't remember where one of you said "When you announce v9.0 on reddit, can you add a request for help creating a .deb linux package?"

It looks like a script will be available even sooner -- #390 (comment)

@rmcrackan
Copy link
Owner Author

All known bugs are patched. I believe these are the last items before a v9 release:

@pixil98

  • Can you work your devops magic with this script and make life easier for our Linux friends?
  • All unit tests should be fixed for linux. Am I correct that they are included in the CI pipeline? And if not, is it difficult to add?

@Mbucari

@pixil98
Copy link
Contributor

pixil98 commented Dec 30, 2022

I can take a look at the script this weekend. It should be doable. All of the unit tests are running, on windows and linux, for each push to main and each pull request to main.

@rmcrackan
Copy link
Owner Author

@pixil98 Thanks. I was hoping to release v9 by now but my family's health imploded. Publishing is easy. If anything goes awry though, I have neither the time nor mental capacity to debug it. Hopefully normalcy will return soon.

@CharlieRussel
Copy link

Seriously @rmcrackan, family is way more important than a software program. Take care and we’ll wait.

@Mbucari
Copy link
Collaborator

Mbucari commented Jan 3, 2023

@rmcrackan I'm sorry about your family situation, but I am glad v9 got delayed. It's nice to have something new and shiny to go along with a major version release, and I think the user ratings fit that bill nicely.

Hope everyone gets better soon!

@pixil98
Copy link
Contributor

pixil98 commented Jan 4, 2023

@rmcrackan Sorry to hear, I hope everyone is getting better. I ended up not having time last weekend to add the deb file generation. We'll still be here when things settle down and you have time and the capacity to work on it.

@wtanksleyjr
Copy link
Contributor

wtanksleyjr commented Jan 5, 2023 via email

@pixil98
Copy link
Contributor

pixil98 commented Jan 6, 2023

@wtanksleyjr oops, that not great. Can you submit an issue and I'll take care of it next chance I get?

@wtanksleyjr
Copy link
Contributor

Actually, just found that was due to a mistake I'd made -- I didn't hand-create the folder, so Docker made it "for" me but with wrong permissions. Even with that fixed, though, it still won't run ... I'll submit a report, but it's almost certainly just me doing something wrong.

@rmcrackan
Copy link
Owner Author

@pixil98 @Mbucari I'm recovered from covid, back in town, and ready to release. Does anything need to be updated in the documentation first? Esp regarding linux or docker?

@Mbucari
Copy link
Collaborator

Mbucari commented Jan 16, 2023 •
edited
Loading

@rmcrackan I updated the linux install instructions.
Nothing else from me before v9

@wtanksleyjr
Copy link
Contributor

wtanksleyjr commented Jan 16, 2023 via email

@Mbucari
Copy link
Collaborator

Mbucari commented Jan 16, 2023

@wtanksleyjr There isn't any Docker documentation. That was all done by @pixil98, and as far as I can tell, it uses default scripts from docker.

This is the action that guilds the docker image.

@wtanksleyjr
Copy link
Contributor

wtanksleyjr commented Jan 16, 2023 via email

@rmcrackan
Copy link
Owner Author

v9 is announced. Let the bug reports begin lol

@wtanksleyjr
Copy link
Contributor

wtanksleyjr commented Jan 16, 2023 via email

@rmcrackan
Copy link
Owner Author

@wtanksleyjr w00h00 -- thanks for that confirmation

@jhofker
Copy link

jhofker commented Jan 16, 2023

Working great on Docker here. Most difficult part was running it initially somewhere else to get the config and DB spun up. Thanks folks!

@wtanksleyjr
Copy link
Contributor

wtanksleyjr commented Jan 16, 2023 via email

@pixil98
Copy link
Contributor

pixil98 commented Jan 16, 2023 •
edited
Loading

I'll write up a readme for it. It should be as simple as invoking it with:

sudo docker run -d \
  -v <path to your existing config directroy>:/config \
  --name libation \
  --restart=always \
  rmcrackan/libation

Disclaimer: I haven't actually tried running the above command.

@wtanksleyjr
Copy link
Contributor

wtanksleyjr commented Jan 16, 2023 via email

@jhofker
Copy link

jhofker commented Jan 16, 2023

I use docker compose, but it should be the same as just doing a docker run

libation:
    image: rmcrackan/libation
    container_name: libation
    volumes:
      - /local/path/for/libation/config:/config
      - /local/path/for/audio/books:/data
      - /tmp/libation:/tmp
    restart: unless-stopped

docker compose up -d

Before doing that, I ran Libation on my Windows machine to set up my account. Then copied over AccountSettings.json, LibationContext.db, and Settings.json to /local/path/for/libation/config (any path on the host machine where you store config-like stuff for your running containers). I also went through Settings.json and made the following adjustments:

  "Books": "/data",
  "InProgress": "/tmp",

I had also updated Serilog.WriteTo.Args.path to /var/logs/libation.log or something like that, but it appears that change was overwritten so it may not matter.

@rmcrackan
Copy link
Owner Author

Thanks all. I like where this docker conversation is going. Looking forward to a readme by one of you folks who clearly know docker better than me.

Docker isn't a high-demand feature. For those power users who like it though, it'll be a really valuable addition. Much like having created the CLI

@pixil98
Copy link
Contributor

pixil98 commented Jan 23, 2023

@wtanksleyjr I've added a docker.md file to the Documentation folder. I tested it out and was able to configure the latest docker image from scratch using those instructions. If you can reproduce the error you were seeing following those instructions, please write up a new issue for it and we can take a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jhofker @wtanksleyjr @CharlieRussel @rmcrackan @Mbucari @pixil98