Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add highlight for nvim-treesitter-context #40

Merged
merged 1 commit into from
Jun 11, 2022

Conversation

smjonas
Copy link
Contributor

@smjonas smjonas commented Jun 11, 2022

Before:
before_nord
After:
after_nord

I simply used the same highlights as SignColumn.

@smjonas
Copy link
Contributor Author

smjonas commented Jun 11, 2022

Maybe we should choose a lighter highlight color instead so it does not fade into the background as much?

@smjonas
Copy link
Contributor Author

smjonas commented Jun 11, 2022

I kind of like colors.selection:
selection_nord

@smjonas smjonas marked this pull request as draft June 11, 2022 10:47
@rmehri01
Copy link
Owner

Hey again, thanks for the PR!

I personally prefer the more subtle active background and I think this should be the default since the plugin seems to take from NormalFloat but you can always override this in your own config if you want.

Also do you mind adding this plugin to the list of supported ones for documentation?

@smjonas
Copy link
Contributor Author

smjonas commented Jun 11, 2022

Hey, ok then let's leave it set to active. I added the plugin to the list of supported plugins in the readme.

@smjonas smjonas marked this pull request as ready for review June 11, 2022 22:05
@rmehri01
Copy link
Owner

Sounds good! And also, sorry I should have specified but there's both the readme and the vim help docs: https://github.com/rmehri01/onenord.nvim/blob/main/doc/onenord.nvim.txt.

@smjonas
Copy link
Contributor Author

smjonas commented Jun 11, 2022

No worries, thanks for reminding me :)

@rmehri01
Copy link
Owner

Looks great, thanks again!

@rmehri01 rmehri01 merged commit ddc9e7d into rmehri01:main Jun 11, 2022
@smjonas
Copy link
Contributor Author

smjonas commented Jun 11, 2022

Thanks for your work on this great color scheme! :D

@smjonas smjonas deleted the ts_context branch June 11, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants