Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[remux] can't launch self-compiled apps with remux from toltec testing channel #122

Closed
ard0gg opened this issue Apr 8, 2021 · 20 comments
Closed
Labels
bug Something isn't working

Comments

@ard0gg
Copy link

ard0gg commented Apr 8, 2021

This might be related to 2.6 Compatibility which is being tracked here: toltec-dev/toltec#322

I have rebuilt Zshelf using the toltec toolchain v2.0.1. If i launch Zshelf from the command line, it will launch right away and is functional. However if I launch Zshelf from Remux, it seems to hang for a bit longer, then will eventually come up, but doesn't seem to load the book data (See Image). I can click on the search button and enter text into the search field, but searches no longer work.

I tried this using remux from stable toltec as well as the testing branch and rebuilding remux using the 2.0.1 toolkit with the same results.

Any thoughts?

@raisjn
Copy link
Member

raisjn commented Apr 8, 2021

yes, i do have thoughts. cc @matteodelabre

toltec-dev/toltec#310 changed how rm2fb works. now the preload library is directly inserted into programs at compile time in toltec and remux doesn't have it automatically turned on for all launched programs

please switch back to stable (to return to the rm2fb shim being turned on for all apps). i will change remux to use the LD_PRELOAD (always) in the mean time.

@raisjn
Copy link
Member

raisjn commented Apr 8, 2021

now that i read your answer more closely, you say it's not because of stable v. testing. can you share your zshelf binary?

@ard0gg
Copy link
Author

ard0gg commented Apr 8, 2021

I must have been mistaken. I switched back to stable branch and it worked. Sorry for confusion.

@raisjn raisjn changed the title Strange Behavior when Launching ZShelf [remux] can't launch self-compiled apps with remux from toltec testing channel Apr 8, 2021
@raisjn raisjn added the bug Something isn't working label Apr 8, 2021
@raisjn
Copy link
Member

raisjn commented Apr 12, 2021

toltec-dev/toltec#338 addresses this (if/when that lands in toltec testing, then remux will be able to launch custom compiled apps)

@matteodelabre
Copy link

Also, to clarify, this issue is not related to the 2.6 system update.

@ralsei
Copy link

ralsei commented Jun 23, 2021

I can confirm that this is a problem that's probably unrelated to rm2fb, since I'm on an rM1 and have the same behavior. This doesn't occur with remux from Toltec stable, even with the same zshelf binary.

@raisjn
Copy link
Member

raisjn commented Jun 23, 2021

how is it occurring from testing? this is surprising to me because I thought we fixed it

@matteodelabre
Copy link

What system version are you on @ralsei? Also, are you using a self-compiled version of zshelf or a Toltec package? If you’re installing it from Toltec, which package version did you install?

@ralsei
Copy link

ralsei commented Jun 23, 2021

I'm on 2.8.0.98, running ZShelf and remux packages from toltec-dev/toltec#366's artifacts. None of my packages are self-compiled.

Downgrading remux specifically to the version from Toltec stable makes ZShelf start fine. So it's likely this is a regression in remux, in my mind.

@matteodelabre
Copy link

Thanks for the details. I’ll try to reproduce the issue this evening.

@matteodelabre
Copy link

matteodelabre commented Jun 23, 2021

Unfortunately I can’t make ZShelf work, because the website that it’s scraping seems to have changed some of its classnames (just opened khanhas/zshelf#6 to track this). So I can’t reproduce this issue right now since I can’t log into the app.

EDIT: Actually this bug is unrelated to that issue.

@ralsei
Copy link

ralsei commented Jun 23, 2021

ZShelf works for me on 1lib.us and displays this error, so it might be unrelated.

@matteodelabre
Copy link

That’s strange, I can’t get the book listing to load. I’ll investigate further.

@matteodelabre
Copy link

matteodelabre commented Jun 23, 2021

Okay, so it seems that I can kind of reproduce the bug. Specifically, ZShelf works fine on its own, but as soon as I start remux, ZShelf won’t load (even after I killed remux). Only after I restart rm2fb will ZShelf work again.

EDIT: This behavior doesn’t seem to always happen. Sometimes ZShelf works fine even inside remux. @ralsei Does the bug happen systematically on your side?

@ralsei
Copy link

ralsei commented Jun 23, 2021

I'm on an rM1, and ZShelf has never worked for me while launching from remux. I don't have to kill remux to get it to work though, I can launch it through the command-line fine, and books are displayed. I don't know how rm2fb plays into this as it is irrelevant for me.

Oxide also launches ZShelf fine (but I wanted better multitasking). remux from Toltec stable (even on 2.8 -- it's not Qt, so...) also launches ZShelf fine.

@matteodelabre
Copy link

Alright, I’ll have to investigate on a rM1 then.

@raisjn
Copy link
Member

raisjn commented Jun 23, 2021

there's some trickiness here because you need to make sure to restart remux when switching channels. aside from that, I am unsure why zshelf in specific isn't working from the PR

@raisjn
Copy link
Member

raisjn commented Jun 24, 2021

based on offline discussion, the issue was that the environment was not properly setup and remux probably needs to add variables to its PATH before launching zshelf. not sure why it worked in stable

@ralsei
Copy link

ralsei commented Jun 25, 2021

adding this file to ~/apps/ launches zshelf fine:

#!/bin/sh
export SHELL=/bin/sh
export PWD=/home/root
export HOME=/home/root
export QT_QPA_PLATFORM=epaper
export QMLSCENE_DEVICE=epaper
export USER=root
export PATH=/opt/bin:/opt/sbin:/home/root/.local/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/sbin:/usr/sbin:/sbin

zshelf

don't know which one of these environment variables is actually causing the issue. but it sure is one of them

@raisjn
Copy link
Member

raisjn commented Aug 16, 2021

fixed in toltec now

@raisjn raisjn closed this as completed Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants