Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

X25519 hashing KDF shouldn't be hard-coded #4

Closed
rmlibre opened this issue Jun 20, 2024 · 1 comment
Closed

X25519 hashing KDF shouldn't be hard-coded #4

rmlibre opened this issue Jun 20, 2024 · 1 comment
Assignees
@rmlibre
Labels
enhancement New feature or request

Comments

@rmlibre
Copy link
Owner

rmlibre commented Jun 20, 2024 •
edited
Loading

Description

The X25519 class calls the DomainKDF class as a hard-coded global during the initialization of 2DH & 3DH key exchange protocols.

Link to relevant file:

Expected behavior

Sub-classes shouldn't need to re-implement X25519 methods just to choose a different hashing KDF.
@rmlibre rmlibre added the enhancement New feature or request label Jun 20, 2024
@rmlibre rmlibre self-assigned this Jun 20, 2024
rmlibre added a commit that referenced this issue Jun 20, 2024
@rmlibre
v0.23.7: refactor(algorithm): remove hard-coded KDF in X25519 met…
0cfd31b 
…hods [#4]
@rmlibre
Copy link
Owner Author

rmlibre commented Jun 20, 2024

Resolved by (0cfd31b).

@rmlibre rmlibre closed this as completed Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmlibre rmlibre

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rmlibre