Release 1.0.0.a6 #75
Merged
Release 1.0.0.a6 #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `assign_params()` method did not return any unused keyword arguments
The micro mod and growth parameters of the trinary unilateral model are now shared by default. Related: #72
The unilateral attributes `is_micro_mod_shared` and `is_growth_shared` are now handled by the bilateral model as well. Fixes: #72
Previously, setting the `max_time` attribute did not change the diagnose time distributions and might have therefore created weird situations. Setting the `max_time` is therefore now forbidden.
I noticed the `is_micro_mod_shared` and `is_growth_shared` attributes are only used when setting params via keyword arguments. And at that point, checking if the gobal parameters are present in the kwargs is sufficient. So, I removed them entirely. Fixes: #72
…a-bilateral-model' into 'dev'
When loading patient data, the `mapping` argument, to convert from the T-stages reported in the data to those the user wants to use in the model, may now be either a dictionary or a function.
The `data` and `load_data_kwargs` are removed from the `likelihood()` method arguments. The most common use case is anyways to preload the patient data. This applies to both the uni- and bilateral llh. In turn, an argument `for_t_stage` was added. It may be used to specify one particular T-stage for which to compute the likelihood. If it is omitted, the llh is computed as normally. This commit also fixes an error in the Bayesian network implementation. Previously, it called the wrong diagnose matrices. Now, it correctly computes the BN llh if no T-stage is specified and only that of the given T-stage if it _is_ provided. BREAKING CHANGE: `data` and `load_data_kwargs` removed from `likelihood()` method.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
==========================================
+ Coverage 81.43% 81.96% +0.53%
==========================================
Files 7 7
Lines 1298 1320 +22
==========================================
+ Hits 1057 1082 +25
+ Misses 241 238 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.