Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting for shared trinary params not accessible via bilateral model #72

Closed
rmnldwg opened this issue Feb 12, 2024 · 0 comments
Closed

Setting for shared trinary params not accessible via bilateral model #72

rmnldwg opened this issue Feb 12, 2024 · 0 comments
Assignees
@rmnldwg
Labels
code quality Improvements w.r.t. readability of code & best practices of coding

Comments

@rmnldwg
Copy link
Owner

rmnldwg commented Feb 12, 2024

From the Bilateral model, it is somewhat cumbersome to set the is_micro_mod_shared and is_growth_shared attributes of the two Unilateral instances. While they can be set via the unilateral_kwargs in the Bilateral model's constructor, changing that afterwards is annoying. Also, the default should probably be True for these attributes, but it is False.
@rmnldwg rmnldwg added the code quality Improvements w.r.t. readability of code & best practices of coding label Feb 12, 2024
@rmnldwg rmnldwg self-assigned this Feb 12, 2024
rmnldwg added a commit that referenced this issue Feb 12, 2024
@rmnldwg
change(uni): trinary params shared by default
764a39e 
The micro mod and growth parameters of the trinary unilateral model are
now shared by default.

Related: #72
rmnldwg added a commit that referenced this issue Feb 12, 2024
@rmnldwg
fix(uni)!: remove is_<x>_shared entirely
85c1974 
I noticed the `is_micro_mod_shared` and `is_growth_shared` attributes
are only used when setting params via keyword arguments. And at that
point, checking if the gobal parameters are present in the kwargs is
sufficient. So, I removed them entirely.

Fixes: #72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmnldwg rmnldwg

Labels
code quality Improvements w.r.t. readability of code & best practices of coding
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

72-setting-for-shared-trinary-params-not-accessible-via-bilateral-model rmnldwg/lymph
1 participant
@rmnldwg