Type reflections #473
Merged
Type reflections #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brndnblck
approved these changes
Jan 3, 2017
| @@ -8,10 +8,12 @@ module GraphQL | |||
| # | |||
| class Directive | |||
| include GraphQL::Define::InstanceDefinable | |||
| accepts_definitions :locations, :name, :description, :arguments, argument: GraphQL::Define::AssignArgument | |||
| accepts_definitions :locations, :name, :description, :arguments, :default, argument: GraphQL::Define::AssignArgument | |||
There was a problem hiding this comment.
For the sake of readability, what do you think about calling this default_directive?
It has better symmetry with the rest of these changes here and seeing things like default = false in isolation feels a bit confusing.
There was a problem hiding this comment.
Oh yeah, that's much more consistent!
| GraphQL::FLOAT_TYPE, | ||
| GraphQL::ID_TYPE, | ||
| ] | ||
|
|
||
| # By default, these are included in a schema printout |
There was a problem hiding this comment.
Huge ❤️ for making this change in the printer as well.
cjoudrey
reviewed
Jan 4, 2017
| @@ -24,6 +34,24 @@ def initialize_copy(other) | |||
| # @return [String, nil] a description for this type | |||
| attr_accessor :description | |||
|
|
|||
| # @return [Boolean] Is this type a predefined introspection type? | |||
| def introspection? | |||
There was a problem hiding this comment.
We may be able to change this
graphql-ruby/lib/graphql/schema/validation.rb
Line 181 in 895d8b7
introspection?.
|
Thanks for taking a look at this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When metaprogramming a GraphQL schema, it comes in handy to check for special types: introspection types, built-in scalars and built-in relay types.
Now,
BaseTyperesponds to checks for those things.Additionally, built-in directives are flagged as such. (There's not really a way to add directives from user-space yet, but ... someday 😎 .)