-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Relay::Node) extend node & nodes fields using definition block #552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks good to me! How about keeping the old test just as an end-to-end test, and to make sure that kwargs are also handled properly?
spec/graphql/relay/node_spec.rb
Outdated
end | ||
|
||
node_field.name = "nod3" | ||
node_field.description = "The Relay Node Field" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed these assign the same values as assigned above, are these meant to be assertions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh. yes. I need ☕️
spec/graphql/relay/node_spec.rb
Outdated
end | ||
|
||
node_field.name = "nodez" | ||
node_field.description = "The Relay Nodes Field" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(same as above)
Added back the tests! |
Sweet :D |
As mentioned in #550 by @rmosolgo. It think its even nicer to allow anything to be redefined on the standard node and nodes field.