feat(Relay::Node) allow passing a custom resolver to the node and nod…#550
Merged
rmosolgo merged 1 commit intormosolgo:masterfrom Feb 17, 2017
Merged
feat(Relay::Node) allow passing a custom resolver to the node and nod…#550rmosolgo merged 1 commit intormosolgo:masterfrom
rmosolgo merged 1 commit intormosolgo:masterfrom
Conversation
Owner
|
Awesome! For some reason I thought that was already possible but obviously not! I'll merge this as-is but a long-term win would be to accept any definition from those methods, something like |
rmosolgo
added a commit
that referenced
this pull request
Feb 17, 2017
feat(Relay::Node) allow passing a custom resolver to the node and nod…
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…es fields
Context:
Wanted to batch the
nodeandnodesfield which requires you to return a lazy object inobject_from_idIf you do that, by default the
nodesfield would return an array of promises / lazy things[Promise, Promise, Promise].Of course,
graphql-rubycant magically guess this is an array of lazy objects, and not all implementations have something likePromise.all([...])so that would be hard to add.With this PR this would allow somebody to override the default resolve when something like this: