-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve scarplet examples; add missing data files #60
Comments
I agree with this: it wasn't immediately clear to me that the example data was included within the GitHub repository, as I had just done a |
Ah, this is unclear, I agree. I've updated the Readme and notebooks headers and made clear that examples and data live in the |
It's still not great to download stuff from the repo. I'm adding a |
Okay, the examples have been refactored and documented with more clarity. I am going to close this and re-open if either reviewer does not have success with installation and testing using conda. |
This issue is in regards to my JOSS review at openjournals/joss-reviews/issues/1066.
In running through the scarplet examples (here and here) I have a couple suggestions.
scarplet/tests
folder.data/grandcanyon.tif
from the Extracting Channels example)In regards to the last point, I can think of two solutions
The text was updated successfully, but these errors were encountered: