Midi import: Tempo from MIDI file is overwritten by default tempo II

[schnitzeltony]

Hi

When importing a MIDI file, the (initial) tempo at tick 0 is ignored.

• It came in for me with 0.9.8 (yeah I'm late...).
• It is similar to Midi import: Tempo from MIDI file is overwritten by default tempo #96 but looks different this time: Can reproduce it on PC.

Interesting: Did set a breakpoint on qtractorMidiFileTempo::addNodeTempo to analyse. My file is setting tempo at tick 0 and changes tempo at later ticks. Later ticks do change tempo properly but first one is ignored: When I play the file to first tempo change, stop and go backward to start tempo is set wrongly to default tempo (120 on fresh system).

Tests were done on latest master

[rncbc]

can you attach the MIDI file and the exact steps to reproduce the issue?

[schnitzeltony]

My test-file to see things are up and performing well:

Lionel Ritchi - Hello.mid.log

It has to be renamed back to *.mid

[schnitzeltony]

The exact steps are:

• Copy file somewhere
• Start qtractor
• Open 'File System' side-pane in qtractor
• Move to the folder the file was copied into
• Drag & drop file into track-space

The initial tempo should be 59 bpm

[rncbc]

thanks

i could reproduce your findings and found some more:

it all seems to work as it should iif you drop the file anywhere but the very first bar or measure of the timeline (bar > 1) whatever current or default tempo is ; iow. the first tempo change in the MIDI file seems to be ignored and overriden by the current default tempo iif the file is dropped to start within the very first bar or measure (1 < bar < 2) which includes the absolute beginning (time = 0) of course.

will look into it and try to fix this idiosyncriticality (just made up the term;))
cheers

[rncbc]

maybe fixed on cb72c22 .
please test && tell

[schnitzeltony]

Tested:

• On PC / master
• On Raspi / midiimportx / cb72c22

-> Idiosyncriticality is gone or does not cause trouble any more :)

Thanks for fast (as usual) solution