Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart rtirq service after resume from suspend #4

Merged
merged 1 commit into from
Jan 9, 2019

Conversation

terencode
Copy link
Contributor

Fix #3

Copy link
Contributor Author

@terencode terencode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the unit has RemainAfterExit=true it doesn't restart it after the suspend target is reached.
I don't know how to tell systemd to restart the unit after target and not just start which fails because of it's already started.

@terencode
Copy link
Contributor Author

terencode commented Jan 8, 2019

I found with the help of some folks over at #systemd three ways to do it:

  1. Create a new unit file without RemainAfterExit=true that will restart rtirq.service with After=suspend.target
  2. Separate the ExecStart and ExecStop into two different units without RemainAfterExit=true.
  3. Leave the unit as it is and just put a file in /usr/lib/systemd/system-sleep to call rtirq.service start which will be triggered when receiving the post argument

Which one do you think is better?

@rncbc rncbc merged commit ed369ce into rncbc:master Jan 9, 2019
@terencode
Copy link
Contributor Author

@rncbc the PR wasn't ready for merging, you need to tell me which approach you prefer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants