Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play the rest of the sample after the loop #39

Open
marcin-koziol opened this issue May 17, 2023 · 3 comments
Open

Play the rest of the sample after the loop #39

marcin-koziol opened this issue May 17, 2023 · 3 comments

Comments

@marcin-koziol
Copy link

It would be nice to have an option to play the "rest" of a sample after note-off with loop enabled, for example, if I have a voice sample with word "boy", I can loop on "o" but I want to have "y" played at the end of the note.

@rncbc
Copy link
Owner

rncbc commented May 19, 2023

well, it was on v0.9.13 (3+ years ago) that someone asked exactly for the opposite--the older behavior was precisely functioning as you asking.

if you're willing to make and revert it yourself, the change is probably as easy as a one-liner:

samplv1/src/samplv1.cpp

Lines 1820 to 1824 in 82f40b7

m_dcf1.env.note_off(&pv->dcf1_env);
m_lfo1.env.note_off(&pv->lfo1_env);
// pv->gen1.setLoop(false);
}
m_notes[pv->note] = nullptr;

ie. just uncomment line 1822 above.

rncbc added a commit that referenced this issue Jun 4, 2023
  sample loop-end point when entering note-off EG release stage.
  (GH issue #39) (EXPERIMENTAL)
@rncbc
Copy link
Owner

rncbc commented Jun 4, 2023

check new Loop End "Release" parameter; samplv1 >= 0.9.30.8git.337a6d

thanks

@marcin-koziol
Copy link
Author

Looks great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants