Fix case where delta is greater than loop length

[ngeiswei]

This may happen when the loop is very short and the note pitch is very
high. In the absence of that fix the m_phase may go out of bound,
including beyond the allocated memory for the sample, producing
glitches and eventually a crash.

[ngeiswei]

I suppose

m_phase -= m_loop_phase1 * std::ceil(delta/m_loop_phase1);

would work as well. It's not clear to me it would be faster because it's a fairly rare case, and even in such rare case it shouldn't loop more than a handful of times. I like that it's slightly shorter however. Let me know what you prefer.

[rncbc]

i'm good on either solution

maybe you can test and make evidence of which one to follow/merge

cheers && thanks again

[ngeiswei]

OK, I'll benchmark both, curious to see if I can measure a difference, probably not... (BTW, thank YOU, for your work thus far).

[ngeiswei]

There is no measurable difference in performance between the loop version and the rounded ratio version, so I've pushed the rounded ratio version as I found it slightly more elegant.