rnp reference updated to 0.16.3

[maxirmx]

No description provided.

[ronaldtse]

Curerent failure:

==> Running TapSyntax#run!
[10](https://github.com/rnpgp/homebrew-rnp/actions/runs/4693384831/jobs/8320297136?pr=32#step:7:11)
==> brew style rnpgp/rnp
[11](https://github.com/rnpgp/homebrew-rnp/actions/runs/4693384831/jobs/8320297136?pr=32#step:7:12)
==> brew readall --aliases rnpgp/rnp
[12](https://github.com/rnpgp/homebrew-rnp/actions/runs/4693384831/jobs/8320297136?pr=32#step:7:13)
==> brew audit --tap=rnpgp/rnp
[13](https://github.com/rnpgp/homebrew-rnp/actions/runs/4693384831/jobs/8320297136?pr=32#step:7:14)
==> FAILED
[14](https://github.com/rnpgp/homebrew-rnp/actions/runs/4693384831/jobs/8320297136?pr=32#step:7:15)
Full audit --tap=rnpgp/rnp output
[15](https://github.com/rnpgp/homebrew-rnp/actions/runs/4693384831/jobs/8320297136?pr=32#step:7:16)
  rnpgp/rnp/rnp:
[16](https://github.com/rnpgp/homebrew-rnp/actions/runs/4693384831/jobs/8320297136?pr=32#step:7:17)
    * fully scope test shell_output calls, e.g. shell_output "#{bin}/rnp"
[17](https://github.com/rnpgp/homebrew-rnp/actions/runs/4693384831/jobs/8320297136?pr=32#step:7:18)
  Error: fully scope test shell_output calls, e.g. shell_output "#{bin}/rnp"
[18](https://github.com/rnpgp/homebrew-rnp/actions/runs/4693384831/jobs/8320297136?pr=32#step:7:19)
  Error: 1 problem in 1 formula detected
[19](https://github.com/rnpgp/homebrew-rnp/actions/runs/4693384831/jobs/8320297136?pr=32#step:7:21)
Error: 1 failed step!
[20](https://github.com/rnpgp/homebrew-rnp/actions/runs/4693384831/jobs/8320297136?pr=32#step:7:22)
brew audit --tap=rnpgp/rnp
[21](https://github.com/rnpgp/homebrew-rnp/actions/runs/4693384831/jobs/8320297136?pr=32#step:7:23)

[maxirmx]

I believe we should not publish bottle. It will contain rnp binary with direct reference to specific version of botan
If botan is updated in homebrew rnp bottle will refer to outdated botan library version as we see in #31

[ronaldtse]

@maxirmx can't we specify a bottle dependency on the particular botan version? The benefit of the bottle is to allow people not to go through compilation, and it is an important benefit.

[maxirmx]

@maxirmx can't we specify a bottle dependency on the particular botan version? The benefit of the bottle is to allow people not to go through compilation, and it is an important benefit.

My understanding is that botan provides a formula to install only the latest version. Thus, even if we specify a dependency on some other version of botan, it will not be installed.

I believe we can

• make a formula that uses bottle if botan version matches and builds from source if botan version does not match
• link botan as static library in homebrew formula. It will eliminate run-time dependency
• link rnp agains more generic reference (botan-2.dylib instead of botan-2.19.dylib). This will probably work but it is something to be done in core rnp build scripts

Also I guess we will need several bottles to make it effective. Botan provides seven:

• arm64_ventura
• arm64_monterey
• arm64_big_sur
• ventura
• monterey
• big_sur
• catalina

This may require cross-compile options that will also go to core rnp build scripts

I suggest we release a simple fix first since keeping the bottle does not look like a one-liner fix

[ronaldtse]

Agree that a simple fix is desired here. We can fix the bottle after. Thanks.

[ronaldtse]

@maxirmx Feel free to merge when ready, thanks.

[maxirmx]

Needs to be recreated to apply pr-pull workflow