Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CentOS/Fedora workflow refactoring #2013

Merged
merged 3 commits into from
Mar 17, 2023
Merged

CentOS/Fedora workflow refactoring #2013

merged 3 commits into from
Mar 17, 2023

Conversation

maxirmx
Copy link
Member

@maxirmx maxirmx commented Mar 15, 2023

  1. Refactor CI: Centos/Fedora workflow #1929
  2. CI: Botan library handling/versioning in CI scripts #2007
  3. Favour pre-packaged automake installation over local build
  4. Favour pre-packaged Ruby installation over local build with rbenv
  5. Create single rnp-devel rpm that contains both shared and static libraries

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (e4c9bea) 83.36% compared to head (dff8dec) 83.35%.

❗ Current head dff8dec differs from pull request most recent head fc9a9f0. Consider uploading reports for the commit fc9a9f0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2013      +/-   ##
==========================================
- Coverage   83.36%   83.35%   -0.01%     
==========================================
  Files         159      159              
  Lines       31897    31897              
==========================================
- Hits        26590    26589       -1     
- Misses       5307     5308       +1     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maxirmx maxirmx force-pushed the maxirmx-ci-centos branch 4 times, most recently from eb11388 to d2d3fe0 Compare March 16, 2023 09:23
@maxirmx maxirmx marked this pull request as ready for review March 16, 2023 15:10
@maxirmx maxirmx requested review from ni4 and ronaldtse March 16, 2023 15:10
Copy link
Contributor

@ronaldtse ronaldtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @maxirmx !

Copy link
Contributor

@ni4 ni4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ni4 ni4 merged commit 3730262 into master Mar 17, 2023
@ni4 ni4 deleted the maxirmx-ci-centos branch March 17, 2023 09:52
@ni4 ni4 added this to the v0.17.0 milestone Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Botan library handling/versioning in CI scripts Refactor CI: Centos/Fedora workflow
3 participants