Skip to content

Commit

Permalink
Issue checkstyle#5897: verified all modules are in no exception configs
Browse files Browse the repository at this point in the history
  • Loading branch information
rnveach committed Mar 10, 2019
1 parent 0bb9038 commit 5327dd5
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 0 deletions.
15 changes: 15 additions & 0 deletions .ci/travis/travis.sh
Expand Up @@ -387,6 +387,21 @@ check-missing-pitests)
exit $fail
;;

verify-no-exception-configs)
wget -q \
https://raw.githubusercontent.com/checkstyle/contribution/master/checkstyle-tester/checks-nonjavadoc-error.xml
wget -q \
https://raw.githubusercontent.com/checkstyle/contribution/master/checkstyle-tester/checks-only-javadoc-error.xml
xmlstarlet sel --net --template -m .//module -v "@name" \
-n checks-nonjavadoc-error.xml -n checks-only-javadoc-error.xml \
| grep -vE "Filter" | grep -v "^$" \
| sort | uniq | sed "s/Check$//" > web.txt
xmlstarlet sel --net --template -m .//module -v "@name" -n config/checkstyle_checks.xml \
| grep -vE "Filter|ImportControl" | grep -v "^$" \
| sort | uniq | sed "s/Check$//" > file.txt
diff -u web.txt file.txt
;;

*)
echo "Unexpected argument: $1"
sleep 5s
Expand Down
5 changes: 5 additions & 0 deletions .travis.yml
Expand Up @@ -248,6 +248,11 @@ matrix:
- DESC="find missing pitests"
- CMD="./.ci/travis/travis.sh check-missing-pitests"

# Ensure that all modules are used in no exception configs
- env:
- DESC="ensure that all modules are used in no exception configs"
- CMD="./.ci/travis/travis.sh verify-no-exception-configs"

script:
- SKIP_FILES1=".github|codeship-*|buddy.yml|appveyor.yml|circleci|distelli-manifest.yml"
- SKIP_FILES2="|fast-forward-merge.sh|LICENSE|LICENSE.apache20|README.md|release.sh|RIGHTS.antlr"
Expand Down

0 comments on commit 5327dd5

Please sign in to comment.