Issue sevntu-checkstyle#618: fixed all violations from RequireFailFor…

…TryCatchInJunitCheck

sevntu-checks/src/test/java/com/github/sevntu/checkstyle/BaseCheckTestSupport.java

@@ -20,6 +20,7 @@
 package com.github.sevntu.checkstyle;
 
 import static java.text.MessageFormat.format;
+import static org.junit.Assert.assertEquals;
 
 import java.io.BufferedReader;
 import java.io.ByteArrayInputStream;
@@ -34,8 +35,6 @@
 import java.util.Locale;
 import java.util.Properties;
 
-import org.junit.Assert;
-
 import com.google.common.collect.Lists;
 import com.puppycrawl.tools.checkstyle.AuditEventUtFormatter;
 import com.puppycrawl.tools.checkstyle.Checker;
@@ -45,7 +44,7 @@
 import com.puppycrawl.tools.checkstyle.api.AuditEvent;
 import com.puppycrawl.tools.checkstyle.api.Configuration;
 
-public abstract class BaseCheckTestSupport extends Assert {
+public abstract class BaseCheckTestSupport {
     private final ByteArrayOutputStream baos = new ByteArrayOutputStream();
     private final PrintStream printStream = new PrintStream(baos);
 

sevntu-checks/src/test/java/com/github/sevntu/checkstyle/UtilsTest.java

@@ -20,6 +20,7 @@
 package com.github.sevntu.checkstyle;
 
 import static com.puppycrawl.tools.checkstyle.internal.TestUtils.assertUtilsClassHasPrivateConstructor;
+import static org.junit.Assert.fail;
 
 import org.junit.Assert;
 import org.junit.Test;
@@ -36,6 +37,7 @@ public void testIsProperUtilsClass() throws ReflectiveOperationException {
     public void testReportInvalidToken() {
         try {
             Utils.reportInvalidToken(TokenTypes.CLASS_DEF);
+            fail();
         }
         catch (IllegalArgumentException ex) {
             Assert.assertEquals("Found unsupported token: CLASS_DEF", ex.getMessage());

sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/AvoidModifiersForTypesCheckTest.java

@@ -20,6 +20,7 @@
 package com.github.sevntu.checkstyle.checks.coding;
 
 import static com.github.sevntu.checkstyle.checks.coding.AvoidModifiersForTypesCheck.MSG_KEY;
+import static org.junit.Assert.fail;
 
 import org.junit.Assert;
 import org.junit.Test;

sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/EmptyPublicCtorInClassCheckTest.java

@@ -20,6 +20,7 @@
 package com.github.sevntu.checkstyle.checks.coding;
 
 import static com.github.sevntu.checkstyle.checks.coding.EmptyPublicCtorInClassCheck.MSG_KEY;
+import static org.junit.Assert.fail;
 
 import org.junit.Assert;
 import org.junit.Test;

sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/ForbidCertainImportsCheckTest.java

@@ -20,6 +20,7 @@
 package com.github.sevntu.checkstyle.checks.coding;
 
 import static com.github.sevntu.checkstyle.checks.coding.ForbidCertainImportsCheck.MSG_KEY;
+import static org.junit.Assert.fail;
 
 import org.junit.Assert;
 import org.junit.Test;

sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/ForbidInstantiationCheckTest.java

@@ -20,6 +20,7 @@
 package com.github.sevntu.checkstyle.checks.coding;
 
 import static com.github.sevntu.checkstyle.checks.coding.ForbidInstantiationCheck.MSG_KEY;
+import static org.junit.Assert.fail;
 
 import org.junit.Assert;
 import org.junit.Test;

sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/NumericLiteralNeedsUnderscoreCheckTest.java

@@ -20,6 +20,7 @@
 package com.github.sevntu.checkstyle.checks.coding;
 
 import static com.github.sevntu.checkstyle.checks.coding.NumericLiteralNeedsUnderscoreCheck.MSG_KEY;
+import static org.junit.Assert.fail;
 
 import java.io.File;
 
@@ -185,6 +186,7 @@ public void testMinSymbolsBeforeCheckingSwitchReflection() throws Exception {
                     new NumericLiteralNeedsUnderscoreCheck();
             final NumericType mockType = PowerMockito.mock(NumericType.class);
             WhiteboxImpl.invokeMethod(check, "minSymbolsBeforeChecking", mockType);
+            fail();
         }
         catch (IllegalStateException ex) {
             Assert.assertTrue(ex.getMessage().startsWith(EXCEPTION_MESSAGE));
@@ -198,6 +200,7 @@ public void testMaxSymbolsUntilUnderscoreSwitchReflection() throws Exception {
                     new NumericLiteralNeedsUnderscoreCheck();
             final NumericType mockType = PowerMockito.mock(NumericType.class);
             WhiteboxImpl.invokeMethod(check, "maxSymbolsUntilUnderscore", mockType);
+            fail();
         }
         catch (IllegalStateException ex) {
             Assert.assertTrue(ex.getMessage().startsWith(EXCEPTION_MESSAGE));
@@ -211,6 +214,7 @@ public void testGetNumericSegmentsSwitchReflection() throws Exception {
                     new NumericLiteralNeedsUnderscoreCheck();
             final NumericType mockType = PowerMockito.mock(NumericType.class);
             WhiteboxImpl.invokeMethod(check, "getNumericSegments", "", mockType);
+            fail();
         }
         catch (IllegalStateException ex) {
             Assert.assertTrue(ex.getMessage().startsWith(EXCEPTION_MESSAGE));
@@ -224,6 +228,7 @@ public void testRemovePrePostfixByTypeSwitchReflection() throws Exception {
                     new NumericLiteralNeedsUnderscoreCheck();
             final NumericType mockType = PowerMockito.mock(NumericType.class);
             WhiteboxImpl.invokeMethod(check, "removePrePostfixByType", "", mockType);
+            fail();
         }
         catch (IllegalStateException ex) {
             Assert.assertTrue(ex.getMessage().startsWith(EXCEPTION_MESSAGE));

sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/RedundantReturnCheckTest.java

@@ -20,6 +20,7 @@
 package com.github.sevntu.checkstyle.checks.coding;
 
 import static com.github.sevntu.checkstyle.checks.coding.RedundantReturnCheck.MSG_KEY;
+import static org.junit.Assert.fail;
 
 import org.junit.Assert;
 import org.junit.Test;

sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/RequireFailForTryCatchInJunitCheckTest.java

@@ -20,6 +20,7 @@
 package com.github.sevntu.checkstyle.checks.coding;
 
 import static com.github.sevntu.checkstyle.checks.coding.RequireFailForTryCatchInJunitCheck.MSG_KEY;
+import static org.junit.Assert.fail;
 
 import org.junit.Assert;
 import org.junit.Test;

sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/coding/ReturnNullInsteadOfBooleanCheckTest.java

@@ -20,6 +20,7 @@
 package com.github.sevntu.checkstyle.checks.coding;
 
 import static com.github.sevntu.checkstyle.checks.coding.ReturnNullInsteadOfBooleanCheck.MSG_KEY;
+import static org.junit.Assert.fail;
 
 import org.junit.Assert;
 import org.junit.Test;

sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/design/AvoidConditionInversionCheckTest.java

@@ -20,6 +20,7 @@
 package com.github.sevntu.checkstyle.checks.design;
 
 import static com.github.sevntu.checkstyle.checks.design.AvoidConditionInversionCheck.MSG_KEY;
+import static org.junit.Assert.fail;
 
 import org.junit.Assert;
 import org.junit.Test;

sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/design/CauseParameterInExceptionCheckTest.java

@@ -20,6 +20,7 @@
 package com.github.sevntu.checkstyle.checks.design;
 
 import static com.github.sevntu.checkstyle.checks.design.CauseParameterInExceptionCheck.MSG_KEY;
+import static org.junit.Assert.fail;
 
 import org.junit.Assert;
 import org.junit.Test;

sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/design/ConstructorWithoutParamsCheckTest.java

@@ -20,6 +20,7 @@
 package com.github.sevntu.checkstyle.checks.design;
 
 import static com.github.sevntu.checkstyle.checks.design.ConstructorWithoutParamsCheck.MSG_KEY;
+import static org.junit.Assert.assertArrayEquals;
 
 import org.junit.Before;
 import org.junit.Test;

sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/design/PublicReferenceToPrivateTypeCheckTest.java

@@ -20,6 +20,7 @@
 package com.github.sevntu.checkstyle.checks.design;
 
 import static com.github.sevntu.checkstyle.checks.design.PublicReferenceToPrivateTypeCheck.MSG_KEY;
+import static org.junit.Assert.fail;
 
 import org.junit.Assert;
 import org.junit.Test;

sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/design/StaticMethodCandidateCheckTest.java

@@ -20,6 +20,7 @@
 package com.github.sevntu.checkstyle.checks.design;
 
 import static com.github.sevntu.checkstyle.checks.design.StaticMethodCandidateCheck.MSG_KEY;
+import static org.junit.Assert.assertArrayEquals;
 
 import java.io.File;
 

sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/naming/UniformEnumConstantNameCheckTest.java

@@ -19,6 +19,8 @@
 
 package com.github.sevntu.checkstyle.checks.naming;
 
+import static org.junit.Assert.fail;
+
 import java.util.Arrays;
 
 import org.junit.Assert;

sevntu-checks/src/test/java/com/github/sevntu/checkstyle/checks/sizes/LineLengthExtendedCheckTest.java

@@ -20,6 +20,7 @@
 package com.github.sevntu.checkstyle.checks.sizes;
 
 import static com.github.sevntu.checkstyle.checks.sizes.LineLengthExtendedCheck.MSG_KEY;
+import static org.junit.Assert.fail;
 
 import org.junit.Assert;
 import org.junit.Test;
@@ -86,6 +87,7 @@ public void testProperty() throws Exception {
 
         try {
             verify(checkConfig, getPath("InputLineLengthExtendedCheck.java"), expected);
+            fail();
         }
         catch (CheckstyleException ex) {
             Assert.assertTrue(ex.getMessage().startsWith("cannot initialize module "