Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update symfony dependencies for Laravel 11 compatibilty #226

Closed
wants to merge 3 commits into from

Conversation

kolaente
Copy link

Only lightly tested - works for me without issues, but I might have missed something in my testing.

@telkins
Copy link

telkins commented Mar 15, 2024

Only lightly tested - works for me without issues, but I might have missed something in my testing.

Why not update all of the symfony packages to include/allow 7.x?

I've just run into this problem when trying to require the latest and I get this:

    - roach-php/core[v3.0.0, ..., v3.0.1] require symfony/css-selector ^6.3.2 -> found symfony/css-selector[v6.3.2, v6.3.12, v6.4.0, v6.4.3] but the package is fixed to v7.0.3 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.

@kolaente
Copy link
Author

I only updated what I had to, to get it running, didn't check anything else. I've updated the other dependencies now as well, but haven't tested them.

@ksassnowski
Copy link
Contributor

Closing this as I already released a new version that does this. Thanks for the PR, though but it turned out to be a bit more complicated because Psalm started throwing a bunch of type errors so it was easier to do it myself.

@kolaente kolaente deleted the patch-1 branch March 23, 2024 09:59
@kolaente
Copy link
Author

Thanks for the new version!

@telkins
Copy link

telkins commented Mar 23, 2024

Closing this as I already released a new version that does this. Thanks for the PR, though but it turned out to be a bit more complicated because Psalm started throwing a bunch of type errors so it was easier to do it myself.

Thx. It's working now for my L10 project, but it does downgrade a couple of packages:

  - Downgrading symfony/css-selector (v7.0.3 => v6.4.3): Extracting archive
  - Downgrading symfony/event-dispatcher (v7.0.3 => v6.4.3): Extracting archive

I thought you might like to know, in case you didn't. 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants