Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StringSourceLocator doesn't "locate" source, but returns a LocatedSource object #43

Closed
asgrim opened this issue Jul 7, 2015 · 2 comments
Closed

StringSourceLocator doesn't "locate" source, but returns a LocatedSource object #43

asgrim opened this issue Jul 7, 2015 · 2 comments
Assignees
@asgrim
Labels
easypick enhancement
Milestone
0.1.0

Comments

@asgrim
Copy link
Member

asgrim commented Jul 7, 2015

Some conceptual "naming" issue that @Ocramius has... StringSourceLocator doesn't "locate" source, but still returns a LocatedSource object.

Solutions for this would be to either create a Source interface that LocatedSource and something else (that the StringSourceLocator would return) implement, or create an abstract parent.

Just need to clarify naming and intent

For reference, original discussion at #32 (comment)
asgrim added a commit that referenced this issue Jul 7, 2015
@asgrim
Added @todo with issue #43
46f76e1
@asgrim asgrim mentioned this issue Jul 7, 2015
Merged
@Ocramius Ocramius mentioned this issue Aug 31, 2015
Merged
@asgrim asgrim mentioned this issue Aug 31, 2015
Closed
Ocramius added a commit that referenced this issue Aug 31, 2015
@Ocramius
Linking issue #123 instead of issue #43
16d4eb5
@asgrim asgrim self-assigned this Oct 6, 2015
@asgrim asgrim added this to the 1.0.0 milestone Oct 6, 2015
@asgrim
Copy link
Member Author

asgrim commented Oct 6, 2015

Will be fixed by resolving #123

@asgrim asgrim mentioned this issue Oct 21, 2015
Merged
@Ocramius
Copy link
Member

Ocramius commented Nov 2, 2015

Handled in #123

@Ocramius Ocramius closed this as completed Nov 2, 2015
@asgrim asgrim mentioned this issue Jan 18, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asgrim asgrim

Labels
easypick enhancement
Projects
None yet
Milestone
0.1.0
Development

No branches or pull requests
2 participants
@Ocramius @asgrim