Improve coverage #24 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
asgrim
force-pushed
the
improve-coverage-issue-24
branch
from
f4fcbf8
to
7cbe796
Compare
| @@ -46,11 +46,21 @@ public function getName() | |||
| */ | |||
| public function getDisplayName() | |||
| { | |||
| return ucfirst(basename($this->name)); | |||
| return basename(str_replace('\\', '/', $this->name)); | |||
There was a problem hiding this comment.
What is the reason for this change?
There was a problem hiding this comment.
because it didn't work before, writing the test discovered it did nothing ;)
There was a problem hiding this comment.
So what is being done here? Is it just a user-friendly identifier?
There was a problem hiding this comment.
yes, exactly, it turns \BetterReflection\Reflection\ReflectionClass into just ReflectionClass for example
There was a problem hiding this comment.
Maybe rename the method to make that clear?
There was a problem hiding this comment.
I've removed this method, probably not required anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue #24