Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating extensions config should be optional #12

Closed
rob006 opened this issue Jan 29, 2020 · 1 comment
Closed

Updating extensions config should be optional #12

rob006 opened this issue Jan 29, 2020 · 1 comment
Assignees
@rob006
Labels
enhancement New feature or request

Comments

@rob006
Copy link
Member

rob006 commented Jan 29, 2020 •
edited
Loading

After #8 configs are updated automatically. There should be a setting to disable this for some extensions - right now this script makes several assumptions (correct package registered at Packagist and GitHub/GitLab repository), which may not always be true (paid extensions may provide static file with sources to translate - no composer package or even GitHub/GitLab repo).

Also, some extensions may use weird versioning (rob006-software/flarum-translations#244) so updating config may be impossible.
@rob006 rob006 added the enhancement New feature or request label Jan 29, 2020
@rob006 rob006 self-assigned this Jan 29, 2020
@rob006 rob006 mentioned this issue May 25, 2020
Closed
rob006 added a commit to rob006-software/flarum-translations that referenced this issue May 25, 2020
@rob006
Add support for premium extensions.
f236fb5 
refs #306
refs rob006-software/flarum-translations-builder#12
rob006 added a commit that referenced this issue May 25, 2020
@rob006
Add support for premium extensions.
47bfb46 
refs rob006-software/flarum-translations#306
refs #12
rob006 added a commit that referenced this issue May 25, 2020
@rob006
Simplify configuration of premium extensions.
f0d486a 
refs #12
@rob006
Copy link
Member Author

rob006 commented May 25, 2020

Closing, since premium extensions are now covered. Other edge cases will be handled when they actually happen.

@rob006 rob006 closed this as completed May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rob006 rob006

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rob006