Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XEP-0184 Fix For Group Chat #687

Merged
merged 1 commit into from Sep 22, 2017
Merged

XEP-0184 Fix For Group Chat #687

merged 1 commit into from Sep 22, 2017

Conversation

bofiaza
Copy link
Contributor

@bofiaza bofiaza commented Feb 26, 2016

Fix:

  • Added type
  • Bare JID (without the resource) instead of the full JID string

@danielgomezrico
Copy link
Contributor

Any update on this? why it is not merged?

@chrisballinger
Copy link
Collaborator

@caipivara Thanks for the reminder. Ideally this would include a comment or link to the spec explaining why this is correct behavior, but whatever.

@chrisballinger chrisballinger merged commit 9d30fd5 into robbiehanson:master Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bofiaza @danielgomezrico @chrisballinger