Refactor thermostat modes & actions #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjernst
commented
Feb 15, 2024
| "frost_protection": "mdi:snowflake", | ||
| "boost": "mdi:rocket-launch", | ||
| "comfort": "mdi:sofa", | ||
| "eco": "mdi:leaf" |
There was a problem hiding this comment.
Built-in presets use the built-in localization for strings but not icon translations, which I think is probably a bug. That's why we have to specify icons for built-in presets here.
adamjernst
commented
Feb 15, 2024
| @@ -89,13 +88,15 @@ class OJMicrolineThermostat( | |||
| ): | |||
| """OJMicrolineThermostat climate.""" | |||
|
|
|||
| _attr_hvac_modes = MODE_LIST | |||
| _attr_hvac_modes: ClassVar[list[HVACMode]] = [HVACMode.HEAT] | |||
There was a problem hiding this comment.
Ruff insists on annotating this as a ClassVar because its default value is shared among all classes (and thus mutations to one affect all). This is never mutated anyway, so it's fine.
robbinjanssen
added
the
enhancement
|
Awesome! I'll add the translations for the other languages in another PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a few changes to better match how other thermostat entities work in Home Assistant:
Whether the thermostat is heating or not is reflected via
HVACActionnotHVACMode. Thermostats now only have a single mode,HEAT, since OJ Microline thermostats can only heat and cannot be turned off via the API. I think this better matches the intended design, where the "action" is whatever the thermostat is choosing to do at a moment in time and the "mode" is a user-changeable item.Presets updated. Instead of the built-in preset "Home", use a custom preset "Schedule". Instead of the built-in preset "None", use a custom preset "Manual". For all presets, use the new Icon Translations feature to give them sensible icons.
Fix min/max temps. We wanted e.g.
max_tempnottarget_temperature_high— the latter is for target temperature ranges, which these thermostats do not support anyway.