Brew plugin fix #65
Merged
Brew plugin fix #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update plugin architecture - completion function in $ZSH/functions/brew - plugins/brew.plugin.zsh only activates
|
I'd like to keep plugins organized within the plugins/ directory structure. Perhaps we need to come up with a convention for how to better nest items within them. ie.. plugins/foo.plugin.zsh What are your thoughts here? |
|
Actually, I opted for this... If you can update these few pull-requests to comply with the new directory structure, I'll get thes pushed out asap! Cheers, |
Dannyzen
pushed a commit
to Dannyzen/oh-my-zsh
that referenced
this pull request
Apr 3, 2016
Just because a widget starts with _ does not mean it should be skipped when rebinding. The only reason widgets need to be skipped is when their function name start with _zsh_highlight_widget*, which is checked later. Example: _expand_alias (^Xa) needs to be wrapped. The exclusion of _* was introduced in 186d800 to fix ohmyzsh#65, but it is not needed. The relevant exclusion of _zsh_highlight_widget* is already enough due to the case statement.
nguymin4
pushed a commit
to nguymin4/oh-my-zsh
that referenced
this pull request
Jul 26, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have restructured the brew plugin to work correctly with the completion function. I have also added a
functionsfolder for custom functions used by plugins. I think this solution fits quite nicely. Thoughts?