Refactored TryInvokeMember #197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok. After taking another look at my pull request, it occurs to me that maybe throwing a large chunk of code at a stranger isn't the best way to begin contributing to open source. If I may make a request though... If you ever have the time I'd really appreciate a couple of words of review of my change set. Thank you. |
|
Thanks for this - I'm going to rip this out for v2 as it's a wad of whacky code - but thank you for the attempt. I'll have a set of tests for Massive as well which will help for refactors like this ;). Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed the comment about refactoring the TryInvokeMember in Massive.cs method and decided to give it a try.