Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toast should have click on close #41

Closed
ahmetsahinoglu opened this issue Jan 20, 2017 · 1 comment
Closed

Toast should have click on close #41

ahmetsahinoglu opened this issue Jan 20, 2017 · 1 comment
Assignees
@serayuzgur
Labels
enhancement
Projects
robe-react-ui
Milestone
1.1.19

Comments

@ahmetsahinoglu
Copy link
Contributor

ahmetsahinoglu commented Jan 20, 2017 •
edited by serayuzgur

  • Robe React UI Version: 1.1.17
  • Node Version: v7.4.0
  • OS / Version: MacOS Sierra 10.12.2
  • Browsers / Versions: Version 55.0.2883.95 (64-bit)

Expected behavior

Toast should have closeOnClick feature

Actual behavior

Nothing happens
@ahmetsahinoglu ahmetsahinoglu mentioned this issue Jan 20, 2017
Closed
@serayuzgur serayuzgur added this to the 1.1.19 milestone Jan 20, 2017
@serayuzgur serayuzgur changed the title When click notification it does not close When click toast it does not close Jan 20, 2017
@serayuzgur serayuzgur self-assigned this Jan 20, 2017
@serayuzgur serayuzgur changed the title When click toast it does not close Toast should have click on close Jan 20, 2017
@serayuzgur
Copy link
Member

click on close is the default behavior now.

serayuzgur added a commit that referenced this issue Jan 23, 2017
@serayuzgur
Toast close on click #41
9affead
serayuzgur added a commit that referenced this issue Jan 23, 2017
@serayuzgur
Toast close on click #41
38b4cf7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@serayuzgur serayuzgur

Labels
enhancement
Projects
robe-react-ui
Done
Milestone
1.1.19
Development

No branches or pull requests
2 participants
@serayuzgur @ahmetsahinoglu