Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline PDF shows in small box #19

Closed
saurabh-mhaisekar opened this issue Sep 20, 2018 · 11 comments
Closed

Inline PDF shows in small box #19

saurabh-mhaisekar opened this issue Sep 20, 2018 · 11 comments
Labels
bug Something isn't working

Comments

@saurabh-mhaisekar
Copy link

Hello Robert,

Thank you for keeping this project alive. I've found an issue while trying to read PDF, the inline PDF shows in very small window, also I cannot resize that box/window.

Attaching the screenshot for your reference.

Also, Can you let us know the roadmap you've planned for the development. I'm planning to contribute in codebase during my free time.

bug

@mckellyln
Copy link

Hi. Thank you also for your Nixnote21 effort.
I have the same issue as above, and also - if I arrow through the pdf pages forward/backward several times - sometimes the pdf is removed from the note.
If there is anything I can do to help please let me know.
I am on Ubuntu 16.04 with latest updates and I used the latest PPA to install nixnote21

@robert7 robert7 added the bug Something isn't working label Sep 24, 2018
@robert7
Copy link
Owner

robert7 commented Sep 24, 2018

Hi,
I know about the problem, but I ignored so far, as I find the "inline PDF display" feature pretty useless. I think opening the PDF in external viewer is much better, that using bad inline view. But I can look, if I can fix it. It seems that it worked better in v2.0.

During test I discovered much more important bug, that the PDF disappears if the note is edited and synced with ""inline PDF display" turned on. This is dangerous and I will fix it as soon as possible.

Meanwhile pls set "inline PDF display" to off.

screen_20180924_01

@mckellyln
Copy link

Yes, thanks, that is what I reported above. I will disable inline PDF for now.
Thank you again for your work.

@robert7
Copy link
Owner

robert7 commented Sep 25, 2018

Ah yes (I did read it, but then forgot :) ). The PDF doesn't disappear, if the "inline display" is turned off.

@robert7
Copy link
Owner

robert7 commented Sep 25, 2018

Should be fixed in 2.0.1-beta4b (I merged to master, this should now be build automagically and be published in the PPA ... let see tomorrow :) ).

I could not figure out how to make height auto adjust, so the height is now fixed to 600px. Width should auto adjust relative to window. The PDF is no longer removed from the note after edit. I found third problem, where PDF could be duplicated after fresh insert into note.

Now it looks like this:
screen_20180925_03

I still like it better with "Show PDF inline" off, but its not that bad :)

@mckellyln
Copy link

Awesome. Thank you again for this and all your effort.

@robert7
Copy link
Owner

robert7 commented Sep 26, 2018

@mckellyln pls test all with the version 2.0.1-beta4b (it is already available in the PPA) and let me know if there are any more problem related to "PDF" attachments (with preview or without)

@mckellyln
Copy link

@robert7 it looks good now at the larger size - but one minor issue still, when I page forward the page number increases, but when I page backward the page number does not decrease.

@robert7
Copy link
Owner

robert7 commented Sep 27, 2018

ok. you are right. I'll fix it

@robert7
Copy link
Owner

robert7 commented Sep 28, 2018

@mckellyln the "page number not decreasing" is fixed in v. 2.1.0-beta4d pls test

@mckellyln
Copy link

@robert7 works great, thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants