Email improvements

[robert7]

Moved here from #18

I just sent another pull request. I made the "email note" function
relative to each note window, instead of app global. It still works
globally, but now also works from every note window. Everything users
might have done before still works, yet there's now new functionality
from each note window.
This is actually a cleaner design anyway since the email function
applies to a particular note, not to the application itself.

[robert7]

@MRC01:
great, I'll take a look later.

Actually I don't like the email function as it is now:

• first it need manual configuration of credentials. Further credential are stored in plain text in config file. This was already raised here: Security issue: email credentials baumgarr/nixnote2#414
• and I also don't like the idea of sending emails directly from note program. It is bit awkward: you can't change subject and/or modify text (e.g. add intro)

So my idea for improvement is just add one config field, there parameters for external email client can be configured - example for Thunderbird: thunderbird -compose "to='john@example.com,kathy@example.com',cc='britney@example.com',subject='dinner',body='How about dinner tonight?',attachment='C:\temp\info.doc,C:\temp\food.doc'" - see thunderbird command line arguments. There should be similar syntax for other popular main clients, even gmail can be scripted someway. (For me I'll be happy with Thunderbird).

Improvement: credentials handled by external client, also some additional text can be easily added and configuration will be easier (no SMTP/user/pwd needed) and later defaults for most often used email clients can be added.

Furher I plan to add function which will print the note in PDF (this is possible already) and automatically email it to Kindle..

[MRC01]

I like your idea. However, my changes don't affect how email works, nor did I change the email function at all. All I did was change how it is invoked. So our changes are completely independent. You can merge my changes now, and if you change how email works later, it will still work seamlessly.

…

On 09/23/2018 02:21 AM, Robert Spiegel wrote: @MRC01 <https://github.com/MRC01>: great, I'll take a look later. Actually I don't like the email function as it is now: * first it need manual configuration of credentials. Further credential are stored in plain text in config file. This was already raised here: baumgarr#414 <baumgarr#414> * and I also don't like the idea of sending emails directly from note program. It is bit awkward: you can't change subject and/or modify text (e.g. add intro) So my idea for improvement is just add one config field, there parameters for external email client can be configured - example for Thunderbird: |thunderbird -compose ***@***.******@***.******@***.***',subject='dinner',body='How about dinner tonight?',attachment='C:\temp\info.doc,C:\temp\food.doc'"| - see thunderbird command line arguments <http://kb.mozillazine.org/Command_line_arguments_%28Thunderbird%29>. There should be similar syntax for other popular main clients, even gmail can be scripted someway. (For me I'll be happy with Thunderbird). Improvement: credentials handled by external client, also some additional text can be easily added and configuration will be easier (no SMTP/user/pwd needed) and later defaults for most often used email clients can be added. Furher I plan to add function which will print the note in PDF (this is possible already) and automatically email it to Kindle <https://www.amazon.com/gp/help/customer/display.html?nodeId=201974220>.. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#23 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEZyAN2RXP8nAcVFehWmakJTF_0VeK4ks5ud1KxgaJpZM4W1nzU>.

[robert7]

yes. of course. I'll review it soon
I just wanted to open a ticket regarding "email changes" .. where I did put together your changes and my plans :)

[MRC01]

Suggestion: add this capability to use a separate email client to send email, yet keep the current code. Pick which method to use in Nixnote preferences. While most Linux distros have an email client, people who don't use it and haven't configured it, will need the existing Nixnote code, despite its limitations.

[robert7]

Yes. I will leave the existing build client as option (as people may already using it).

[robert7]

@MRC01: your changes are merged - thx!
I also created a "develop" branch. So next PRs should probably be directed to this branch.
There are minor changed to the build script build-with-qmake.sh, but you probably already noticed.