Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Improvement Suggestions #15

Open
robertDurst opened this issue Aug 17, 2019 · 3 comments
Open

Implement Improvement Suggestions #15

robertDurst opened this issue Aug 17, 2019 · 3 comments
Labels
good first issue Good for newcomers

Comments

@robertDurst
Copy link
Owner

robertDurst commented Aug 17, 2019

Johansten on Keybase had some good suggestions for improving the speed here:

Gotcha.. Quick thoughts:

  1. You don't need to randomize more than once. The first thing that ed25519 does with the seed anyway is run it through a hash. You can just += 1 for all the following seeds.
  2. You don't need to deserialize the privkey until you know the pubkey was a match
  3. You don't need to do the match in base32, convert your needle to binary instead and match it that way. You probably need a mask first, since you might end up with bitstrings w/ lengths that aren't multiples of eight.
  4. In Update dependencies #3, you don't need to calculate the checksum unless you have a partial match already
@robertDurst
Copy link
Owner Author

Another recommendation from johansten: checkout PlasmaPower/nano-vanity and webmaster128/lisk-vanity

@robertDurst
Copy link
Owner Author

Finished 2 with #17

@robertDurst
Copy link
Owner Author

Finished 1 and 4 with #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant