uppercase inputs and decouple key gen from encoding #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@charlie-wasp interested in your input here. Nothing controversial, but some of the rust does not quite seem kosher so helpful suggestions are welcome 😄 |
|
LGTM! |
|
@robertDurst it seems, I'm late at the party, sorry for the late reply 😅 Yes, I agree, something doesn't feel right. I'll try to play with it and propose changes, if I would come up with any |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the second point from #15 and closes #14 by decoupling private and public key encoding from the keypair generation and also by uppercasing the prefix/postfix input to make the cli more intuitive (and because case does not matter here).