Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in Delta Labs Sector 3 - HST Observation #774

Closed
rg3 opened this issue May 20, 2023 · 2 comments
Closed

Crash in Delta Labs Sector 3 - HST Observation #774

rg3 opened this issue May 20, 2023 · 2 comments

Comments

@rg3
Copy link

rg3 commented May 20, 2023

When approaching the bathroom door in front of the window that overlooks the bridge, the game crashes for me.

Platform: Linux
GPU: Radeon RX 6700

If playing in windowed mode, I get the following message on the terminal:

Sys_Error: Volatile constant buffer ToneMappingConstants has maxVersions = 16, which is insufficient.
shutdown terminal support
Segmentation fault (core dumped)

If playing on fullscreen, I get the following message:

FATAL: recursed fatal error:
Volatile constant buffer ToneMappingConstants has maxVersions = 16, which is insufficient.
Cannot open a command list that is already open
shutdown terminal support
Segmentation fault (core dumped)

The crash happens both on Wayland and XWayland (SDL_VIDEODRIVER=x11).

@rg3
Copy link
Author

rg3 commented May 21, 2023

Forgot to paste patch. This fixes the issue for me, but I have no idea of what I'm doing. 😃

diff --git a/neo/renderer/Passes/TonemapPass.h b/neo/renderer/Passes/TonemapPass.h
index 793eec14..21e6930f 100644
--- a/neo/renderer/Passes/TonemapPass.h
+++ b/neo/renderer/Passes/TonemapPass.h
@@ -48,7 +48,7 @@ public:
 	{
 		bool isTextureArray = false;
 		uint32_t histogramBins = 256;
-		uint32_t numConstantBufferVersions = 16;
+		uint32_t numConstantBufferVersions = 32;
 		nvrhi::IBuffer* exposureBufferOverride = nullptr;
 		idImage* colorLUT = nullptr;
 	};

@RobertBeckebans
Copy link
Owner

I need to look deeper in the code why this is an issue at all but for now it is a good workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants