Fixes errors in redis_out_close and issue #445 #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the redis_out_close(), send QUIT instead of PING to Redis server for disconnection. Besides, expect both "+OK" and ":0" as legitimate responses. This also resolves the issue robertdavidgraham#445. Tested with the latest stable version of Redis server (5.0.5).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
redis_out_close():send
QUITinstead ofPINGto the connected Redis server for disconnection. ThePINGwas a wrong command here.expect
+OKor:0as legitimate responses from the server, other than+PONG.This resolves the issue #445
Tested with the latest stable version of Redis server (5.0.5).